linux-kernel - [PATCH 2/2] scsi: ufs: Document NOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250617095611.89229-3-avri.altman@sandisk.com>
Date: Tue, 17 Jun 2025 12:56:11 +0300
From: Avri Altman <avri.altman@...disk.com>
To: "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bart Van Assche <bvanassche@....org>,
	Avri Altman <avri.altman@...disk.com>
Subject: [PATCH 2/2] scsi: ufs: Document NOP_OUT transaction code

UPIU_TRANSACTION_NOP_OUT is 0x0, which is the default value after
memset. Comment out the explicit assignment and leave it as
documentation.

Signed-off-by: Avri Altman <avri.altman@...disk.com>
---
 drivers/ufs/core/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2048aca09fc..84165b45467d 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2835,7 +2835,7 @@ static inline void ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp)
 	memset(ucd_req_ptr, 0, sizeof(struct utp_upiu_req));
 
 	ucd_req_ptr->header = (struct utp_upiu_header){
-		.transaction_code = UPIU_TRANSACTION_NOP_OUT,
+		/* .transaction_code = UPIU_TRANSACTION_NOP_OUT = 0x0, */
 		.task_tag = lrbp->task_tag,
 	};
 }
-- 
2.25.1