linux-kernel - Re: [PATCH 0/3] pci: cx23885: Convert to use string choices helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e98d3174-92a0-468e-be0d-99646e7eb857@jjverkuil.nl>
Date: Tue, 17 Jun 2025 13:12:07 +0200
From: Hans Verkuil <hans@...erkuil.nl>
To: Pan Chuang <panchuang@...o.com>, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] pci: cx23885: Convert to use string choices helper

Hi Pan Chuang,

On 13/06/2025 10:21, Pan Chuang wrote:
> Remove hard-coded strings by using the str_read_write(),
> str_yes_no() and str_enabled_disabled() helper.
> 
> Pan Chuang (3):
>   pci: cx23885: altera-ci: Use str_read_write() helper
>   pci: cx23885: cimax2: Use str_read_write() helper
>   pci: cx23885: cx23888-ir: Use str_yes_no() and str_enabled_disabled()
>     helper

The opinion of the media maintainers is that there is very little gain
in changing this in existing code. For new drivers it is fine, but for
these old drivers we prefer to just leave it as-is.

So I'll drop this series and the cobalt patch.

Regards,

	Hans

> 
>  drivers/media/pci/cx23885/altera-ci.c  |  2 +-
>  drivers/media/pci/cx23885/cimax2.c     |  2 +-
>  drivers/media/pci/cx23885/cx23888-ir.c | 36 +++++++++++++-------------
>  3 files changed, 20 insertions(+), 20 deletions(-)
>