linux-kernel - Re: [PATCH] EDAC/amd64: Correct number of UMCs for Family 19h Models 70h-7fh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250617114154.GAaFFUgo6SVroOaP02@fat_crate.local>
Date: Tue, 17 Jun 2025 13:41:54 +0200
From: Borislav Petkov <bp@...en8.de>
To: Avadhut Naik <avadhut.naik@....com>
Cc: linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	yazen.ghannam@....com, mario.limonciello@....com,
	reox <mailinglist@...x.at>
Subject: Re: [PATCH] EDAC/amd64: Correct number of UMCs for Family 19h Models
 70h-7fh

On Fri, Jun 13, 2025 at 12:51:35AM +0000, Avadhut Naik wrote:
> AMD's Family 19h-based Models 70h-7fh support 4 UMCs per processor die.
> 
> The amd64_edac module, however, assumes only 2 UMCs are supported since
> max_mcs variable for the models has not been explicitly set to 4. The
> same results in incomplete or incorrect memory information being logged
> to dmesg by the module during initialization in some instances.
> 
> Fixes: 6c79e42169fe ("EDAC/amd64: Add support for ECC on family 19h model 60h-7Fh")
> Reported-by: reox <mailinglist@...x.at>
> Closes: https://lore.kernel.org/all/27dc093f-ce27-4c71-9e81-786150a040b6@reox.at/
> Signed-off-by: Avadhut Naik <avadhut.naik@....com>
> Cc: stable@...nel.org
> ---
>  drivers/edac/amd64_edac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 90f0eb7cc5b9..390f5756b66e 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3879,6 +3879,7 @@ static int per_family_init(struct amd64_pvt *pvt)
>  			break;
>  		case 0x70 ... 0x7f:
>  			pvt->ctl_name			= "F19h_M70h";
> +			pvt->max_mcs			= 4;
>  			pvt->flags.zn_regs_v2		= 1;
>  			break;
>  		case 0x90 ... 0x9f:
> 
> base-commit: 855b5de2e562c07d6cda4deb08d09dc2e0e2b18d
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette