linux-kernel - Re: [PATCH net v1] mlxbf_gige: return EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250618123405.GN1699@horms.kernel.org>
Date: Wed, 18 Jun 2025 13:34:05 +0100
From: Simon Horman <horms@...nel.org>
To: David Thompson <davthompson@...dia.com>
Cc: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
 available

On Tue, Jun 17, 2025 at 08:07:37PM +0000, David Thompson wrote:
> > -----Original Message-----
> > From: Simon Horman <horms@...nel.org>
> > Sent: Monday, June 16, 2025 8:45 AM
> > To: David Thompson <davthompson@...dia.com>
> > Cc: andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> > kuba@...nel.org; pabeni@...hat.com; u.kleine-koenig@...libre.com;
> > netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Asmaa Mnebhi
> > <asmaa@...dia.com>
> > Subject: Re: [PATCH net v1] mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not
> > available
> > 
> > On Fri, Jun 13, 2025 at 06:51:29PM +0000, David Thompson wrote:
> > > The message "Error getting PHY irq. Use polling instead"
> > > is emitted when the mlxbf_gige driver is loaded by the kernel before
> > > the associated gpio-mlxbf driver, and thus the call to get the PHY IRQ
> > > fails since it is not yet available. The driver probe() must return
> > > -EPROBE_DEFER if acpi_dev_gpio_irq_get_by() returns the same.
> > >
> > > Signed-off-by: David Thompson <davthompson@...dia.com>
> > > Reviewed-by: Asmaa Mnebhi <asmaa@...dia.com>
> > 
> > Thanks David,
> > 
> > I as a bug fix this needs a Fixes tag, which you can add by simply replying to this
> > email.
> > 
> > Else we can treat it as an enhancement for net-next.
> 
> Yes, good point Simon.
> 
> This patch is a fix, so should have the following Fixes tag:
> 	Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")

Thanks David,

I notice that in the meantime that this has been marked as Changes Requested
in patchwork. Presumably due to my earlier comment about a Fixes tag.

Could you post a v2 with the Fixes tag?

Feel free to also include
Reviewed-by: Simon Horman <horms@...nel.org>