linux-kernel - Re: [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo_oTWWX-PNNA_Dpq0fjbmhzoLCgd77NfDO=Q_JZ8hZ-g@mail.gmail.com>
Date: Wed, 18 Jun 2025 14:56:26 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Krzysztof Hałasa <khalasa@...p.pl>
Cc: Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>, 
	linux-pm@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] imx8m-blk-ctrl: set ISI panic write hurry level

On Fri, 9 May 2025 at 11:26, Krzysztof Hałasa <khalasa@...p.pl> wrote:
>
> Apparently, ISI needs cache settings similar to LCDIF.
> Otherwise we get artefacts in the image.
> Tested on i.MX8MP.
>
> Signed-off-by: Krzysztof Hałasa <khalasa@...p.pl>

Applied for next, thanks!

Kind regards
Uffe


>
> diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> index 912802b5215b..5c83e5599f1e 100644
> --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c
> @@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = {
>  #define  LCDIF_1_RD_HURRY      GENMASK(15, 13)
>  #define  LCDIF_0_RD_HURRY      GENMASK(12, 10)
>
> +#define ISI_CACHE_CTRL         0x50
> +#define  ISI_V_WR_HURRY                GENMASK(28, 26)
> +#define  ISI_U_WR_HURRY                GENMASK(25, 23)
> +#define  ISI_Y_WR_HURRY                GENMASK(22, 20)
> +
>  static int imx8mp_media_power_notifier(struct notifier_block *nb,
>                                 unsigned long action, void *data)
>  {
> @@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb,
>                 regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL,
>                                 FIELD_PREP(LCDIF_1_RD_HURRY, 7) |
>                                 FIELD_PREP(LCDIF_0_RD_HURRY, 7));
> +               /* Same here for ISI */
> +               regmap_set_bits(bc->regmap, ISI_CACHE_CTRL,
> +                               FIELD_PREP(ISI_V_WR_HURRY, 7) |
> +                               FIELD_PREP(ISI_U_WR_HURRY, 7) |
> +                               FIELD_PREP(ISI_Y_WR_HURRY, 7));
>         }
>
>         return NOTIFY_OK;
>
> --
> Krzysztof "Chris" Hałasa
>
> Sieć Badawcza Łukasiewicz
> Przemysłowy Instytut Automatyki i Pomiarów PIAP
> Al. Jerozolimskie 202, 02-486 Warszawa