linux-kernel - Re: [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for the PinePhone Pro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DAPPKP3OWLMU.C6HXTY24NZ4H@cknow.org>
Date: Wed, 18 Jun 2025 15:54:42 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Olivier Benjamin" <olivier.benjamin@...tlin.com>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>
Cc: "Thomas Petazzoni" <thomas.petazzoni@...tlin.com>,
 <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Fix the panel compatible for
 the PinePhone Pro

On Wed Jun 18, 2025 at 12:32 AM CEST, Olivier Benjamin wrote:
> As documented in its bindings, the compatible for the Himax HX8394
> MIPI-DSI LCD panel controller is in 2 parts.
> The PinePhone Pro DTS currently only specifies the first part of the
> compatible, generating a warning.
>
> Signed-off-by: Olivier Benjamin <olivier.benjamin@...tlin.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> index 04ba4c4565d0a205e2e46d7535c6a3190993621d..5ebc380a24df86ba7172b0950b89cac56b61c507 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
> @@ -479,7 +479,7 @@ mipi_out_panel: endpoint {
>  	};
>  
>  	panel@0 {
> -		compatible = "hannstar,hsd060bhw4";
> +		compatible = "hannstar,hsd060bhw4", "himax,hx8394";
>  		reg = <0>;
>  		backlight = <&backlight>;
>  		reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;

Reviewed-by: Diederik de Haas <didi.debian@...ow.org>

But I'd actually suggest to combine it with patch 3 and use that
opportunity to also fix the property sorting, so you'd get 1 patch which
fixes all of the panel issues.

Cheers,
  Diederik

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)