linux-kernel - Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support for 4M baudrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fb36656-5aeb-45f4-9460-acc8a2bc3c61@molgen.mpg.de>
Date: Wed, 18 Jun 2025 16:44:18 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
Cc: marcel@...tmann.org, luiz.dentz@...il.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, linux-bluetooth@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 amitkumar.karwar@....com, sherry.sun@....com, manjeet.gupta@....com
Subject: Re: [PATCH v2 1/2] dt-bindings: net: bluetooth: nxp: Add support for
 4M baudrate

Dear Neeraj,


Thank you for the patch.

Am 18.06.25 um 16:20 schrieb Neeraj Sanjay Kale:
> Add support for 4000000 as secondary baudrate.

Could you specify how you tested this, that means, how did you set the 
speed, and then do the test, that it actually works at that speed.

> Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@....com>
> ---
> v2: Use the available 'max-speed' device tree property. (Krzysztof)
> ---
>   .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml  | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index 3ab60c70286f..4a1b6ea48a2f 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -34,6 +34,12 @@ properties:
>         This property depends on the module vendor's
>         configuration.
>   
> +  max-speed:
> +    enum:
> +      - 3000000
> +      - 4000000
> +    default: 3000000
> +
>     firmware-name:
>       maxItems: 1
>   
> @@ -78,6 +84,7 @@ examples:
>           bluetooth {
>               compatible = "nxp,88w8987-bt";
>               fw-init-baudrate = <3000000>;
> +            max-speed = <4000000>;
>               firmware-name = "uartuart8987_bt_v0.bin";
>               device-wakeup-gpios = <&gpio 11 GPIO_ACTIVE_HIGH>;
>               nxp,wakein-pin = /bits/ 8 <18>;


Kind regards,

Paul