linux-kernel - Re: [PATCH 16/16] spi: falcon: mark falcon_sflash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f81ec27e-8c3a-4998-a31c-dcb4453bbe0c@sirena.org.uk>
Date: Wed, 18 Jun 2025 16:08:47 +0100
From: Mark Brown <broonie@...nel.org>
To: Shiji Yang <yangshiji66@...look.com>
Cc: linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-spi@...r.kernel.org,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	John Crispin <john@...ozen.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 16/16] spi: falcon: mark falcon_sflash_xfer() as static

On Wed, Jun 18, 2025 at 10:53:29PM +0800, Shiji Yang wrote:
> Fix the following missing-prototypes build warning:
> 
> drivers/spi/spi-falcon.c:97:5: error: no previous prototype for 'falcon_sflash_xfer' [-Werror=missing-prototypes]
>    97 | int falcon_sflash_xfer(struct spi_device *spi, struct spi_transfer *t,
>       |     ^~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Shiji Yang <yangshiji66@...look.com>

I believe there's no actual dependency on the rest of the series?  In
general it is better not to mix patches for different subsystems in a
single series unless there's some interaction between them, it just
means people get more mail and makes it a bit less clear how things
should be applied.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)