linux-kernel - Re: [PATCH AUTOSEL 6.15 101/110] ALSA: seq: Remove unused snd_seq_queue_client_leave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFLXcQc6Wg41gPSJ@lappy>
Date: Wed, 18 Jun 2025 11:12:49 -0400
From: Sasha Levin <sashal@...nel.org>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: patches@...ts.linux.dev, stable@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>, perex@...ex.cz, tiwai@...e.com,
	yuehaibing@...wei.com, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.15 101/110] ALSA: seq: Remove unused
 snd_seq_queue_client_leave_cells

On Sun, Jun 01, 2025 at 11:51:02PM +0000, Dr. David Alan Gilbert wrote:
>* Sasha Levin (sashal@...nel.org) wrote:
>
>Hi Sasha,
>
>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>
>> [ Upstream commit 81ea9e92941091bb3178d49e63b13bf4df2ee46b ]
>>
>> The last use of snd_seq_queue_client_leave_cells() was removed in 2018
>> by
>> commit 85d59b57be59 ("ALSA: seq: Remove superfluous
>> snd_seq_queue_client_leave_cells() call")
>>
>> Remove it.
>>
>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>> Signed-off-by: Takashi Iwai <tiwai@...e.de>
>> Link: https://patch.msgid.link/20250502235219.1000429-4-linux@treblig.org
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>
>> NO This commit should not be backported to stable kernel trees for
>> several reasons:
>
>I'd agree with that big fat NO - unless it makes your life easier backporting
>a big pile of other stuff.
>I'm a bit curious about:
>  a) How it got picked up by autosel - I'm quite careful not to include
>     'fixes' tags to avoid them getting picked up.

autosel does it's analysis based on LLMs rather than just commit tags.

>  b) Given it's got a big fat no, why is it posted here?

I was trying to be too smart :)

My scripts got confused by the "YES" later on in the explanation.

Now dropped!

-- 
Thanks,
Sasha