linux-kernel - Re: [PATCH] hwmon: (corsair-cpro) Change dependency from HID to HIDRAW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1144cef1-c4af-4fd4-93ae-70a2fcf67f54@roeck-us.net>
Date: Wed, 18 Jun 2025 08:41:43 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: dongfengweixiao@...il.com, jdelvare@...e.com, linux@...ck-us.ne
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (corsair-cpro) Change dependency from HID to
 HIDRAW

On 6/18/25 00:28, dongfengweixiao@...il.com wrote:
> From: "Dee.H.Y" <dongfengweixiao@...il.com>
> 
> This patch updates the dependency of the CORSAIR_CPRO driver in the
> hwmon subsystem. Previously, the driver relied on HID, but now it

 From Documentation/process/submitting-patches.rst:

Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.

What is "previously" ? The driver always used HID_CONNECT_HIDRAW.

Either case, I do not think this patch is warranted. CONFIG_HIDRAW
creates /dev/hidraw for use by applications. This driver does not
need such an application to work. If you disagree, please provide
logs showing that the driver does not work with CONFIG_HIDRAW=n.

Thanks,
Guenter

> depends on HIDRAW. This change is aligned with the implementation
> in the `ccp_probe()` function, where `HID_CONNECT_HIDRAW` is used,
> indicating that the HID raw interface is required for proper operation.
> 
> Signed-off-by: Dee.H.Y <dongfengweixiao@...il.com>
> ---
>   drivers/hwmon/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 08a3c863f80a..3f128cacb486 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -475,7 +475,7 @@ config SENSORS_CHIPCAP2
>   
>   config SENSORS_CORSAIR_CPRO
>   	tristate "Corsair Commander Pro controller"
> -	depends on HID
> +	depends on HIDRAW
>   	help
>   	  If you say yes here you get support for the Corsair Commander Pro
>   	  controller.