linux-kernel - RE: [PATCH 1/1] EDAC/igen6: Fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB7134B9350A5DF2AA69640D418972A@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Wed, 18 Jun 2025 15:42:28 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>
CC: Borislav Petkov <bp@...en8.de>, "marmarek@...isiblethingslab.com"
	<marmarek@...isiblethingslab.com>, James Morse <james.morse@....com>, "Mauro
 Carvalho Chehab" <mchehab@...nel.org>, Robert Richter <rric@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] EDAC/igen6: Fix NULL pointer dereference

Hi Tony,

> From: Luck, Tony <tony.luck@...el.com>
> [...]
> >
> > This issue occurred because one memory controller was fused off by
> 
> Maybe "disabled by BIOS" rather than "fused off by BIOS".

The phrase "disabled by BIOS" should be more appropriate.
Will update it in v2. Thanks.
 
> > the BIOS but the igen6_edac driver still checked all the memory
> > controllers, including this absent one, to identify the source of the
> [...]
> >
> > -	if (lmc < res_cfg->num_imc)
> > +	if (lmc < res_cfg->num_imc) {
> >  		igen6_printk(KERN_WARNING, "Expected %d mcs, but
> only %d detected.",
> >  			     res_cfg->num_imc, lmc);
> 
> KERN_WARNING seems overly dramatic. BIOS likely had good reasons to
> disable the memory controller (e.g. it isn't connected to any DIMM slots on
> the motherboard for this system). So there's nothing actually wrong that
> needs to be fixed.

Yes. That's true. 

> KERN_INFO is enough. Perhaps KERN_DEBUG?

Will change the log level to "KERN_DEBUG" in v2 to reduce noise.

- Qiuxu