linux-kernel - RE: [PATCH] scsi: fnic: fix missing dma mapping error in `fnic_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SJ0PR11MB58961170A23E4D151BC2FAD1C372A@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date: Wed, 18 Jun 2025 15:58:56 +0000
From: "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To: Thomas Fourier <fourier.thomas@...il.com>
CC: "Satish Kharat (satishkh)" <satishkh@...co.com>, "Sesidhar Baddela
 (sebaddel)" <sebaddel@...co.com>, "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>, "Martin K. Petersen"
	<martin.petersen@...cle.com>, "Arulprabhu Ponnusamy (arulponn)"
	<arulponn@...co.com>, "Arun Easi (aeasi)" <aeasi@...co.com>, "Gian Carlo
 Boffa (gcboffa)" <gcboffa@...co.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: fnic: fix missing dma mapping error in
 `fnic_send_frame()`

On Tuesday, June 17, 2025 11:57 PM, Thomas Fourier <fourier.thomas@...il.com> wrote:
>
> `dma_map_XXX()` can fail and should be tested for errors with
> `dma_mapping_error().`
>
> Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses")
> Signed-off-by: Thomas Fourier <fourier.thomas@...il.com>
> ---
> drivers/scsi/fnic/fnic_fcs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
> index 1e8cd64f9a5c..103ab6f1f7cd 100644
> --- a/drivers/scsi/fnic/fnic_fcs.c
> +++ b/drivers/scsi/fnic/fnic_fcs.c
> @@ -636,6 +636,8 @@ static int fnic_send_frame(struct fnic *fnic, void *frame, int frame_len)
> unsigned long flags;
>
> pa = dma_map_single(&fnic->pdev->dev, frame, frame_len, DMA_TO_DEVICE);
> +     if (dma_mapping_error(&fnic->pdev->dev, pa))
> +             return -ENOMEM;
>
> if ((fnic_fc_trace_set_data(fnic->fnic_num,
> FNIC_FC_SEND | 0x80, (char *) frame,
> --
> 2.43.0
>
>

Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@...co.com>

Regards,
Karan