linux-kernel - Re: [Intel-wired-lan] [PATCH] igc: Make the const read-only array supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eaed1854-ec73-43e1-b5c9-5a2be8268ffc@intel.com>
Date: Wed, 18 Jun 2025 18:29:36 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Colin Ian King <colin.i.king@...il.com>
CC: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S
 . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH] igc: Make the const read-only array
 supported_sizes static

From: Colin Ian King <colin.i.king@...il.com>
Date: Wed, 18 Jun 2025 14:54:08 +0100

> Don't populate the const read-only array supported_sizes on the
> stack at run time, instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

> ---
>  drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c
> index b23b9ca451a7..8a110145bfee 100644
> --- a/drivers/net/ethernet/intel/igc/igc_tsn.c
> +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c
> @@ -431,7 +431,7 @@ static u8 igc_fpe_get_frag_size_mult(const struct igc_fpe_t *fpe)
>  
>  u32 igc_fpe_get_supported_frag_size(u32 frag_size)
>  {
> -	const u32 supported_sizes[] = {64, 128, 192, 256};
> +	static const u32 supported_sizes[] = { 64, 128, 192, 256 };
>  
>  	/* Find the smallest supported size that is >= frag_size */
>  	for (int i = 0; i < ARRAY_SIZE(supported_sizes); i++) {

Thanks,
Olek