linux-kernel - [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250618191929.2382821-1-alok.a.tiwari@oracle.com>
Date: Wed, 18 Jun 2025 12:19:21 -0700
From: Alok Tiwari <alok.a.tiwari@...cle.com>
To: perex@...ex.cz, tiwai@...e.com, phasta@...nel.org,
        andriy.shevchenko@...ux.intel.com, linux-sound@...r.kernel.org
Cc: alok.a.tiwari@...cle.com, linux-kernel@...r.kernel.org
Subject: [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH_DI2L SDIN

Correct the index to use codec[i] to match the loop iteration, not codec[1].

Is this a mistake or intentional?

Thanks,
Alok

propose changes
Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
---
 sound/pci/intel8x0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index 51e7f1f1a48e..b521cec20333 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -2249,7 +2249,7 @@ static int snd_intel8x0_mixer(struct intel8x0 *chip, int ac97_clock,
 			tmp |= chip->ac97_sdin[0] << ICH_DI1L_SHIFT;
 			for (i = 1; i < 4; i++) {
 				if (pcm->r[0].codec[i]) {
-					tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;
+					tmp |= chip->ac97_sdin[pcm->r[0].codec[i]->num] << ICH_DI2L_SHIFT;
 					break;
 				}
 			}
-- 
2.47.1