linux-kernel - Re: [PATCH] platform: cznic: turris-omnia-mcu: Use new GPIO line value setter callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MdrpRQyQ84PRAi_6QsEDFcpNU9G140xiEAYHob12UbCfQ@mail.gmail.com>
Date: Wed, 18 Jun 2025 22:30:13 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Marek Behún <kabel@...nel.org>
Cc: linux-gpio@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH] platform: cznic: turris-omnia-mcu: Use new GPIO line
 value setter callbacks

On Wed, Jun 18, 2025 at 8:54 PM Marek Behún <kabel@...nel.org> wrote:
>
> On Wed, Jun 18, 2025 at 08:47:33PM +0200, Marek Behún wrote:
> > On Wed, Jun 18, 2025 at 03:20:15PM +0200, Bartosz Golaszewski wrote:
> > > On Wed, Jun 18, 2025 at 2:43 PM Marek Behún <kabel@...nel.org> wrote:
> > > >
> > > > struct gpio_chip now has callbacks for setting line values that return
> > > > an integer, allowing to indicate failures. Convert the driver to using
> > > > them.
> > > >
> > > > Signed-off-by: Marek Behún <kabel@...nel.org>
> > > > ---
> > >
> > > What's going on with this patch? I sent it a few days ago, now you
> > > just resent it without changes. Who should pick it up?
> >
> > I didn't see any patch for this driver, only for gpio-moxtet (for which
> > I sent R-b). Did I overlook it?
>
> OMG I see it now. Sorry.
>
> There is one difference, though. Your change makes omnia_gpio_set() return
> -EINVAL on a GPIO that does not support output direction. I put -ENOTSUPP
> there, since -ENOTSUPP is also returned by direction_input() and
> direction_output() methods in this case.
>
> I don't know if -EINVAL or -ENOTSUPP is more consistent, though. Feel free
> to apply your version (you can also add my R-b tag).
>
> Marek

I don't care that much, I can take this one but please leave an
official Acked-by in that case.

Bart