linux-kernel - Re: [PATCH] scripts: gdb: move MNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a01d8c8e-21b7-488d-8fa2-0a8710bc1e9a@oracle.com>
Date: Wed, 18 Jun 2025 14:06:23 -0700
From: Stephen Brennan <stephen.s.brennan@...cle.com>
To: Johannes Berg <johannes@...solutions.net>, linux-kernel@...r.kernel.org
Cc: Jan Kiszka <jan.kiszka@...mens.com>, Kieran Bingham
 <kbingham@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Berg <johannes.berg@...el.com>,
        Benjamin Berg <benjamin.berg@...el.com>
Subject: Re: [PATCH] scripts: gdb: move MNT_* constants to gdb-parsed

On 6/18/25 06:46, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> Since these are now no longer defines, but in an enum.
> 
> Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
> Reviewed-by: Benjamin Berg <benjamin.berg@...el.com>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

The exact same change was already submitted and discussed here:

https://lore.kernel.org/all/20250601055027.3661480-1-tony.ambardar@gmail.com/

I don't know what tree this would go through, so I can't tell whether it
was picked up or not. But I think there's consensus that it's a good
fix, and several folks have written or reviewed the change.

Thanks,
Stephen

> ---
>  scripts/gdb/linux/constants.py.in | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index fd6bd69c5096..d5e3069f42a7 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -73,12 +73,12 @@ if IS_BUILTIN(CONFIG_MODULES):
>      LX_GDBPARSED(MOD_RO_AFTER_INIT)
>  
>  /* linux/mount.h */
> -LX_VALUE(MNT_NOSUID)
> -LX_VALUE(MNT_NODEV)
> -LX_VALUE(MNT_NOEXEC)
> -LX_VALUE(MNT_NOATIME)
> -LX_VALUE(MNT_NODIRATIME)
> -LX_VALUE(MNT_RELATIME)
> +LX_GDBPARSED(MNT_NOSUID)
> +LX_GDBPARSED(MNT_NODEV)
> +LX_GDBPARSED(MNT_NOEXEC)
> +LX_GDBPARSED(MNT_NOATIME)
> +LX_GDBPARSED(MNT_NODIRATIME)
> +LX_GDBPARSED(MNT_RELATIME)
>  
>  /* linux/threads.h */
>  LX_VALUE(NR_CPUS)