linux-kernel - Re: [PATCH RESEND] selftests: add missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97e0eae8-954a-40dd-91ee-4a0a7cc4b9b4@linuxfoundation.org>
Date: Wed, 18 Jun 2025 15:24:59 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Chen Linxuan <chenlinxuan@...ontech.com>,
 Christian Brauner <brauner@...nel.org>, Shuah Khan <shuah@...nel.org>
Cc: zhanjun@...ontech.com, niecheng1@...ontech.com,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH RESEND] selftests: add missing include

On 6/9/25 20:08, Chen Linxuan wrote:
> I failed to build this test on Ubuntu 24.04.
> Compiler complained about undefined functions mount, umount and some
> mount related flags.
> 
> Signed-off-by: Chen Linxuan <chenlinxuan@...ontech.com>
> ---
>   tools/testing/selftests/pid_namespace/pid_max.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_namespace/pid_max.c
> index 96f274f0582b6..c3ee8a2eff75b 100644
> --- a/tools/testing/selftests/pid_namespace/pid_max.c
> +++ b/tools/testing/selftests/pid_namespace/pid_max.c
> @@ -12,6 +12,7 @@
>   #include <syscall.h>
>   #include <sys/mount.h>

Hmm. I see mount.h included here?

>   #include <sys/wait.h>
> +#include <sys/mount.h>

You are adding a duplicate include for the same file?

>   
>   #include "../kselftest_harness.h"
>   #include "../pidfd/pidfd.h"

thanks,
-- Shuah