| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <f5e679bc-ac84-426b-987e-ade14229f7b0@amd.com> Date: Wed, 18 Jun 2025 16:57:16 -0500 From: "Moger, Babu" <bmoger@....com> To: Reinette Chatre <reinette.chatre@...el.com>, babu.moger@....com, corbet@....net, tony.luck@...el.com, Dave.Martin@....com, james.morse@....com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com Cc: x86@...nel.org, hpa@...or.com, akpm@...ux-foundation.org, paulmck@...nel.org, rostedt@...dmis.org, thuth@...hat.com, ardb@...nel.org, gregkh@...uxfoundation.org, seanjc@...gle.com, thomas.lendacky@....com, pawan.kumar.gupta@...ux.intel.com, perry.yuan@....com, yosry.ahmed@...ux.dev, kai.huang@...el.com, xiaoyao.li@...el.com, peterz@...radead.org, kan.liang@...ux.intel.com, mario.limonciello@....com, xin3.li@...el.com, sohil.mehta@...el.com, chang.seok.bae@...el.com, andrew.cooper3@...rix.com, ebiggers@...gle.com, ak@...ux.intel.com, xin@...or.com, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v6 4/8] x86/resctrl: Implement "io_alloc" enable/disable handlers Hi Reinette, On 6/18/2025 3:32 PM, Reinette Chatre wrote: > Hi Babu, > > On 6/18/25 12:27 PM, Moger, Babu wrote: > >> On 6/17/25 22:51, Reinette Chatre wrote: > >>> On 6/11/25 2:23 PM, Babu Moger wrote: > >>>> static inline struct rdt_hw_resource *resctrl_to_arch_res(struct rdt_resource *r) >>>> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c >>>> index 885026468440..3bdcd53b3ce3 100644 >>>> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c >>>> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c >>>> @@ -229,6 +229,46 @@ bool resctrl_arch_get_cdp_enabled(enum resctrl_res_level l) >>>> return rdt_resources_all[l].cdp_enabled; >>>> } >>>> >>>> +inline bool resctrl_arch_get_io_alloc_enabled(struct rdt_resource *r) >>> >>> As indicated by lkp the inline usage needs to be fixed. >> >> I am assuming that you are referring to >> https://www.kernel.org/doc/html/next/process/coding-style.html#the-inline-disease > > No. I am referring to the lkp test report of an issue detected by sparse. Looks like > the message was not cc'd to lkml so I cannot provide link. I paste it below. You are in > "To:". Yes. I saw that report. It's strange why it was not cc'd to lkml. Happened few times before. > >> >> I will remove inline attribute. > > The goal was to fix the broken usage of inline, but you are right that it may > not be needed here. Sure. Will remove inline. > > Here is the original report: Thanks Babu > >> Date: Fri, 13 Jun 2025 12:18:35 +0800 >> From: kernel test robot <lkp@...el.com> >> To: Babu Moger <babu.moger@....com>, corbet@....net, tony.luck@...el.com, reinette.chatre@...el.com, Dave.Martin@....com, james.morse@....com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com >> CC: oe-kbuild-all@...ts.linux.dev, x86@...nel.org, hpa@...or.com, akpm@...ux-foundation.org, paulmck@...nel.org, rostedt@...dmis.org, thuth@...hat.com, ardb@...nel.org, gregkh@...uxfoundation.org, seanjc@...gle.com, thomas.lendacky@....com, pawan.kumar.gupta@...ux.intel.com, perry.yuan@....com, yosry.ahmed@...ux.dev, kai.huang@...el.com, xiaoyao.li@...el.com, peterz@...radead.org, kan.liang@...ux.intel.com, mario.limonciello@....com, xin3.li@...el.com, sohil.mehta@...el.com >> Subject: Re: [PATCH v6 5/8] fs/resctrl: Add user interface to enable/disable io_alloc feature >> Message-ID: <202506131104.d1oo8NWe-lkp@...el.com> >> In-Reply-To: <b3d8e2ccd23b295f3735fc9f5420458cfc18a896.1749677012.git.babu.moger@....com> >> >> Hi Babu, >> >> kernel test robot noticed the following build warnings: >> >> [auto build test WARNING on brauner-vfs/vfs.all] >> [also build test WARNING on linus/master v6.16-rc1 next-20250612] >> [cannot apply to tip/x86/core aegl/next] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch#_base_tree_information] >> >> url: https://github.com/intel-lab-lkp/linux/commits/Babu-Moger/x86-cpufeatures-Add-support-for-L3-Smart-Data-Cache-Injection-Allocation-Enforcement/20250612-053050 >> base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all >> patch link: https://lore.kernel.org/r/b3d8e2ccd23b295f3735fc9f5420458cfc18a896.1749677012.git.babu.moger%40amd.com >> patch subject: [PATCH v6 5/8] fs/resctrl: Add user interface to enable/disable io_alloc feature >> config: i386-randconfig-061-20250613 (https://download.01.org/0day-ci/archive/20250613/202506131104.d1oo8NWe-lkp@intel.com/config) >> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 >> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250613/202506131104.d1oo8NWe-lkp@intel.com/reproduce) >> >> If you fix the issue in a separate patch/commit (i.e. not just a new version of >> the same patch/commit), kindly add following tags >> | Reported-by: kernel test robot <lkp@...el.com> >> | Closes: https://lore.kernel.org/oe-kbuild-all/202506131104.d1oo8NWe-lkp@intel.com/ >> >> sparse warnings: (new ones prefixed by >>) >> fs/resctrl/rdtgroup.c: note: in included file: >>>> include/linux/resctrl.h:553:46: sparse: sparse: marked inline, but without a definition >>>> include/linux/resctrl.h:553:46: sparse: sparse: marked inline, but without a definition >>>> include/linux/resctrl.h:553:46: sparse: sparse: marked inline, but without a definition >>>> include/linux/resctrl.h:553:46: sparse: sparse: marked inline, but without a definition >> >> vim +553 include/linux/resctrl.h >> >> 48e63934badb71 Babu Moger 2025-06-11 545 >> 48e63934badb71 Babu Moger 2025-06-11 546 /** >> 48e63934badb71 Babu Moger 2025-06-11 547 * resctrl_arch_get_io_alloc_enabled() - Get io_alloc feature state. >> 48e63934badb71 Babu Moger 2025-06-11 548 * @r: The resctrl resource. >> 48e63934badb71 Babu Moger 2025-06-11 549 * >> 48e63934badb71 Babu Moger 2025-06-11 550 * Return: >> 48e63934badb71 Babu Moger 2025-06-11 551 * true if io_alloc is enabled or false if disabled. >> 48e63934badb71 Babu Moger 2025-06-11 552 */ >> 48e63934badb71 Babu Moger 2025-06-11 @553 inline bool resctrl_arch_get_io_alloc_enabled(struct rdt_resource *r); >> 48e63934badb71 Babu Moger 2025-06-11 554 >> >> -- >> 0-DAY CI Kernel Test Service >> https://github.com/intel/lkp-tests/wiki > > Reinette >
Powered by blists - more mailing lists