linux-kernel - Re: [GIT PULL] Crypto library fixes for v6.16-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dmkpj6q5mjw3bet6orkhcxtxwof4gufxknbroyfuwzrzcmdru6@4dmuaznfvkvz>
Date: Wed, 18 Jun 2025 18:05:37 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Eric Biggers <ebiggers@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>, 
	"Jason A. Donenfeld" <Jason@...c4.com>, Kees Cook <kees@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [GIT PULL] Crypto library fixes for v6.16-rc3

On Wed, Jun 18, 2025 at 09:59:18PM +0000, Eric Biggers wrote:
> On Wed, Jun 18, 2025 at 05:40:27PM -0400, Kent Overstreet wrote:
> > On Wed, Jun 18, 2025 at 12:49:58PM -0700, Eric Biggers wrote:
> > > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:
> > > 
> > >   Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git tags/libcrypto-for-linus
> > > 
> > > for you to fetch changes up to 9d4204a8106fe7dc80e3f2e440c8f2ba1ba47319:
> > > 
> > >   lib/crypto/poly1305: Fix arm64's poly1305_blocks_arch() (2025-06-16 12:51:34 -0700)
> > > 
> > > ----------------------------------------------------------------
> > > 
> > > - Fix a regression in the arm64 Poly1305 code
> > 
> > Some more tests too, perhaps? :)
> > 
> > This was a bit of a scary one, since poly1305 was returning an
> > inconsistent result, not total garbage. Meaning most of the tests
> > passed, but fortunately the migrate tests read data written by userspace
> > with a different library.
> 
> Yep, I have a KUnit test for Poly1305 planned.  Actually, I already wrote a
> preliminary one and used it to test this patch.  I just haven't sent it out for
> review quite yet, since so far it's just a one-off test that isn't too complete,
> and I'm not satisfied with it quite yet.  I'd like to reuse the
> hash-test-template.h I'm adding for SHA-2
> (https://lore.kernel.org/linux-crypto/20250616014019.415791-5-ebiggers@kernel.org/)
> which would result in a more complete test.  I'd also like to include tests for
> some of the overflow cases that are specific to Poly1305.
> 
> So we're kind of still in an early stage where we're defining what the KUnit
> testing for lib/crypto/ is going to look like.  I am working on it, though!

I do a little dance any time someeone says something like that about
testing. Bravo :)

(And now, back to sifting through the rest of the rc1 breakage.)