linux-kernel - Re: [PATCH 8/9] lib/crypto/x86: move arch/x86/lib/crypto/ to lib/crypto/x86/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <983d7906-6510-4867-978f-4f937b29224b@intel.com>
Date: Tue, 17 Jun 2025 17:41:09 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Eric Biggers <ebiggers@...nel.org>, <linux-crypto@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, "Jason A . Donenfeld" <Jason@...c4.com>,
	Ard Biesheuvel <ardb@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-mips@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-riscv@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
	<sparclinux@...r.kernel.org>, <x86@...nel.org>
Subject: Re: [PATCH 8/9] lib/crypto/x86: move arch/x86/lib/crypto/ to
 lib/crypto/x86/

On 6/17/2025 3:27 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Move the contents of arch/x86/lib/crypto/ into lib/crypto/x86/.
> 
> The new code organization makes a lot more sense for how this code
> actually works and is developed.  In particular, it makes it possible to
> build each algorithm as a single module, with better inlining and dead
> code elimination.  For a more detailed explanation, see the patchset
> which did this for the CRC library code:
> https://lore.kernel.org/r/20250607200454.73587-1-ebiggers@kernel.org/.
> Also see the patchset which did this for SHA-512:
> https://lore.kernel.org/linux-crypto/20250616014019.415791-1-ebiggers@kernel.org/
> 
> This is just a preparatory commit, which does the move to get the files
> into their new location but keeps them building the same way as before.
> Later commits will make the actual improvements to the way the
> arch-optimized code is integrated for each algorithm.
> 
> arch/x86/lib/crypto/.gitignore is intentionally kept for now.  See
> https://lore.kernel.org/r/CAHk-=whu2fb22rEy6+oKx1-+NCHuWucZepvD0H2MD38DrJVKtg@mail.gmail.com/
> I'll remove it later after some time has passed.
> 

After this change, arch/x86/lib/ has a lone empty directory crypto with
the .gitignore file.

Instead, would it be cleaner to get rid of the crypto directory
altogether and update the .gitignore of the parent?

As per the link above, commit 2df0c02dab82 ("x86 boot build: make git
ignore stale 'tools' directory") says this:

"So when removing directories that had special .gitignore patterns, make
sure to add a new gitignore entry in the parent directory for the no
longer existing subdirectory."

With that change,

Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>


> Signed-off-by: Eric Biggers <ebiggers@...gle.com>