linux-kernel - Re: [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250617175634.73ce12c9@kernel.org>
Date: Tue, 17 Jun 2025 17:56:34 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Álvaro Fernández Rojas <noltari@...il.com>
Cc: jonas.gorski@...il.com, florian.fainelli@...adcom.com, andrew@...n.ch,
 olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, vivien.didelot@...il.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, dgcbueu@...il.com
Subject: Re: [PATCH net-next v4 00/14] net: dsa: b53: fix BCM5325 support

On Sat, 14 Jun 2025 09:59:46 +0200 Álvaro Fernández Rojas wrote:
> These patches get the BCM5325 switch working with b53.
> 
> The existing brcm legacy tag only works with BCM63xx switches.
> We need to add a new legacy tag for BCM5325 and BCM5365 switches, which
> require including the FCS and length.
> 
> I'm not really sure that everything here is correct since I don't work for
> Broadcom and all this is based on the public datasheet available for the
> BCM5325 and my own experiments with a Huawei HG556a (BCM6358).
> 
> Both sets of patches have been merged due to the change requested by Jonas
> about BRCM_HDR register access depending on legacy tags.

From the commit messages sounds like the support for these switches
never really worked properly. So I'll drop the Fixes tag when applying.
No objection if you'd like to argue with stable folks for stable
inclusion once these reach Linus, given what lands in stable these days.
But I don't want to implicitly support that by applying with the Fixes
tags.