linux-kernel - Re: [PATCH RESEND] firmware: qemu_fw_cfg: Do not hard depend on CONFIG_HAS_IOPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202506181300.OUXh1Amh-lkp@intel.com>
Date: Wed, 18 Jun 2025 13:50:19 +0800
From: kernel test robot <lkp@...el.com>
To: Takashi Iwai <tiwai@...e.de>, Gabriel Somlo <somlo@....edu>,
	"Michael S . Tsirkin" <mst@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, Fabian Vogt <fvogt@...e.de>,
	linux-kernel@...r.kernel.org, qemu-devel@...gnu.org
Subject: Re: [PATCH RESEND] firmware: qemu_fw_cfg: Do not hard depend on
 CONFIG_HAS_IOPORT_MAP

Hi Takashi,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.16-rc2 next-20250617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Takashi-Iwai/firmware-qemu_fw_cfg-Do-not-hard-depend-on-CONFIG_HAS_IOPORT_MAP/20250617-001546
base:   linus/master
patch link:    https://lore.kernel.org/r/20250616161408.26748-1-tiwai%40suse.de
patch subject: [PATCH RESEND] firmware: qemu_fw_cfg: Do not hard depend on CONFIG_HAS_IOPORT_MAP
config: arm64-randconfig-r073-20250618 (https://download.01.org/0day-ci/archive/20250618/202506181300.OUXh1Amh-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250618/202506181300.OUXh1Amh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506181300.OUXh1Amh-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/firmware/qemu_fw_cfg.c: In function 'fw_cfg_io_cleanup':
>> drivers/firmware/qemu_fw_cfg.c:207:3: error: implicit declaration of function 'ioport_unmap' [-Werror=implicit-function-declaration]
     207 |   ioport_unmap(fw_cfg_dev_base);
         |   ^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/ioport_unmap +207 drivers/firmware/qemu_fw_cfg.c

2d6d60a3d3eca5 Marc-André Lureau 2018-02-28  199  
75f3e8e47f3810 Gabriel Somlo     2016-01-28  200  /* clean up fw_cfg device i/o */
75f3e8e47f3810 Gabriel Somlo     2016-01-28  201  static void fw_cfg_io_cleanup(void)
75f3e8e47f3810 Gabriel Somlo     2016-01-28  202  {
75f3e8e47f3810 Gabriel Somlo     2016-01-28  203  	if (fw_cfg_is_mmio) {
75f3e8e47f3810 Gabriel Somlo     2016-01-28  204  		iounmap(fw_cfg_dev_base);
75f3e8e47f3810 Gabriel Somlo     2016-01-28  205  		release_mem_region(fw_cfg_p_base, fw_cfg_p_size);
75f3e8e47f3810 Gabriel Somlo     2016-01-28  206  	} else {
75f3e8e47f3810 Gabriel Somlo     2016-01-28 @207  		ioport_unmap(fw_cfg_dev_base);
75f3e8e47f3810 Gabriel Somlo     2016-01-28  208  		release_region(fw_cfg_p_base, fw_cfg_p_size);
75f3e8e47f3810 Gabriel Somlo     2016-01-28  209  	}
75f3e8e47f3810 Gabriel Somlo     2016-01-28  210  }
75f3e8e47f3810 Gabriel Somlo     2016-01-28  211  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki