linux-kernel - Re: [PATCH v2 03/17] dmaengine: ti: k3-udma: move static inline helper functions to header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fabe8565-cd27-4117-ba64-23022f1942ae@ti.com>
Date: Wed, 18 Jun 2025 13:34:53 +0530
From: "Adivi, Sai Sree Kartheek" <s-adivi@...com>
To: Siddharth Vadapalli <s-vadapalli@...com>
CC: Peter Ujfalusi <peter.ujfalusi@...il.com>, Vinod Koul <vkoul@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Santosh
 Shilimkar <ssantosh@...nel.org>, <dmaengine@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <praneeth@...com>,
        <vigneshr@...com>, <u-kumar1@...com>, <a-chavda@...com>,
        <p-mantena@...com>
Subject: Re: [PATCH v2 03/17] dmaengine: ti: k3-udma: move static inline
 helper functions to header file

Hi Siddharth,

On 6/12/2025 4:35 PM, Siddharth Vadapalli wrote:
> On Thu, Jun 12, 2025 at 12:45:07PM +0530, Sai Sree Kartheek Adivi wrote:
>> Move static inline helper functions in k3-udma.c to k3-udma.h header
>> file for better separation and re-use.
>>
>> Signed-off-by: Sai Sree Kartheek Adivi <s-adivi@...com>
>> ---
>>   drivers/dma/ti/k3-udma.c | 108 --------------------------------------
>>   drivers/dma/ti/k3-udma.h | 109 +++++++++++++++++++++++++++++++++++++++
> 
> Since this patch and the previous two patches seem to have the same
> objective of moving contents from "k3-udma.c" to "k3-udma.h" for the
> purpose of re-use, could they be squashed?

I split them up to make the changes easier to review, bisect or revert 
if needed. They're logically distinct changes even if the overall goal 
is similar.

If there's a strong preference to squash them, I can do that but I'd 
prefer keeping them separate.

> 
> Regards,
> Siddharth.