linux-kernel - Re: [RFC 1/2] lib/vsprintf: Add support for pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc5fb92c-6636-4dce-bc66-181345f79abf@redhat.com>
Date: Wed, 18 Jun 2025 10:44:20 +0200
From: David Hildenbrand <david@...hat.com>
To: Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Rasmus Villemoes <linux@...musvillemoes.dk>,
 Sergey Senozhatsky <senozhatsky@...omium.org>, Petr Mladek
 <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>,
 Jonathan Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t

On 18.06.25 10:37, Anshuman Khandual wrote:
> 
> 
> On 18/06/25 1:48 PM, David Hildenbrand wrote:
>> On 18.06.25 06:12, Anshuman Khandual wrote:
>>> Add a new format for printing page table entries.
>>>
>>> Cc: Petr Mladek <pmladek@...e.com>
>>> Cc: Steven Rostedt <rostedt@...dmis.org>
>>> Cc: Jonathan Corbet <corbet@....net>
>>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>>> Cc: David Hildenbrand <david@...hat.com>
>>> Cc: linux-doc@...r.kernel.org
>>> Cc: linux-kernel@...r.kernel.org
>>> Cc: linux-mm@...ck.org
>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
>>> ---
>>>    Documentation/core-api/printk-formats.rst | 14 ++++++++++++++
>>>    lib/vsprintf.c                            | 20 ++++++++++++++++++++
>>>    mm/memory.c                               |  5 ++---
>>>    scripts/checkpatch.pl                     |  2 +-
>>>    4 files changed, 37 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst
>>> index 4b7f3646ec6ce..75a110b059ee1 100644
>>> --- a/Documentation/core-api/printk-formats.rst
>>> +++ b/Documentation/core-api/printk-formats.rst
>>> @@ -689,6 +689,20 @@ Rust
>>>    Only intended to be used from Rust code to format ``core::fmt::Arguments``.
>>>    Do *not* use it from C.
>>>    +Page Table Entry
>>> +----------------
>>> +
>>> +::
>>> +        %ppte
>>> +
>>> +Print standard page table entry pte_t.
>>> +
>>> +Passed by reference.
>>
>> Curious, why the decision to pass by reference?
> 
> Just to make this via %p<> based address mechanism. But wondering
> will it be better for the pte to be represented via value instead
> of reference ?

We commonly pass ptes to functions through value, not reference, that's 
why I am asking.

-- 
Cheers,

David / dhildenb