linux-kernel - RE: [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSCPR01MB14647A762408F08501D4A20DDFF72A@OSCPR01MB14647.jpnprd01.prod.outlook.com>
Date: Wed, 18 Jun 2025 08:54:54 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Prabhakar Mahadev Lad
	<prabhakar.mahadev-lad.rj@...renesas.com>, "robh@...nel.org"
	<robh@...nel.org>, Biju Das <biju.das.jz@...renesas.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"john.madieu@...il.com" <john.madieu@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"magnus.damm@...il.com" <magnus.damm@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH nodes

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Tuesday, June 17, 2025 5:32 PM
> To: John Madieu <john.madieu.xa@...renesas.com>
> Subject: Re: [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH
> nodes
> 
> Hi John,
> 
> On Wed, 11 Jun 2025 at 11:01, John Madieu <john.madieu.xa@...renesas.com>
> wrote:
> > Add GBETH nodes to RZ/G3E (R9A09G047) SoC DTSI.
> >
> > Reviewed-by: Biju Das <biju.das.jz@...renesas.com>
> > Tested-by: Biju Das <biju.das.jz@...renesas.com>
> > Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -759,6 +759,213 @@ csi2cru: endpoint@0 {
> >                                 };
> >                         };
> >                 };
> > +
> > +               eth0: ethernet@...30000 {
> 
> [...]
> 
> > +                       mdio {
> 
> You probably want to add a label (mdio0) here...
> 

Noted.

> > +                               compatible = "snps,dwmac-mdio";
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +                       };
> 
> > +               eth1: ethernet@...40000 {
> 
> [...]
> 
> > +                       mdio {
> 
> ... and here (mdio1), for easier configuration of the PHY in the board-
> specific DTS.
> 

Noted.

Will address that in v3.

> > +                               compatible = "snps,dwmac-mdio";
> > +                               #address-cells = <1>;
> > +                               #size-cells = <0>;
> > +                       };
> 
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Regards,
John

> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds