linux-kernel - Aw: Re: [net-next v4 2/3] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-86a5b58b-a74a-48be-80ae-aa306e95f214-1750238697100@trinity-msg-rest-gmx-gmx-live-b647dc579-2m42j>
Date: Wed, 18 Jun 2025 09:24:57 +0000
From: Frank Wunderlich <frank-w@...lic-files.de>
To: horms@...nel.org, linux@...web.de
Cc: nbd@....name, sean.wang@...iatek.com, lorenzo@...nel.org,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, daniel@...rotopia.org,
 arinc.unal@...nc9.com
Subject: Aw: Re: [net-next v4 2/3] net: ethernet: mtk_eth_soc: add consts
 for irq index

Hi,

> Gesendet: Mittwoch, 18. Juni 2025 um 10:36
> Von: "Simon Horman" <horms@...nel.org>
> Betreff: Re: [net-next v4 2/3] net: ethernet: mtk_eth_soc: add consts for irq index
>
> On Mon, Jun 16, 2025 at 10:07:35AM +0200, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@...lic-files.de>
> > 
> > Use consts instead of fixed integers for accessing IRQ array.
> > 
> > Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> > ---
> > v4:
> > - calculate max from last (rx) irq index and use it for array size too
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

thanks for review and the RB

i thinking about changing the const names to this:

MTK_ETH_IRQ_SHARED	=> MTK_FE_IRQ_SHARED
MTK_ETH_IRQ_TX		=> MTK_FE_IRQ_TX
MTK_ETH_IRQ_RX		=> MTK_FE_IRQ_RX
MTK_ETH_IRQ_MAX		=> MTK_FE_IRQ_NUM

because of i currently working on RSS/LRO patches and here MTK_FE_IRQ_NUM is used as name 
with same meaning like my current MTK_ETH_IRQ_MAX (where max should be same as RX and NUM
is one more because it is a count).
Current IRQs also target the MTK frame-engine which is different to the PDMA RX engine
used for RSS/LRO later, so MTK_ETH_IRQ_RX and MTK_ETH_IRQ_MAX are maybe misleading when RSS/LRO 
support will come in.

can i change the consts like this and keep your RB?

regards Frank