linux-kernel - RE: [PATCH v4] net: usb: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH7PR11MB8455242B4E160C281D8AC9B39A72A@PH7PR11MB8455.namprd11.prod.outlook.com>
Date: Wed, 18 Jun 2025 01:41:42 +0000
From: "Miao, Jun" <jun.miao@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "sbhatta@...vell.com" <sbhatta@...vell.com>, "oneukum@...e.com"
	<oneukum@...e.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"qiang.zhang@...ux.dev" <qiang.zhang@...ux.dev>
Subject: RE: [PATCH v4] net: usb: Convert tasklet API to new bottom half
 workqueue mechanism

>
>On Sun, 15 Jun 2025 09:53:15 +0800 Jun Miao wrote:
>> -static void usbnet_bh_tasklet(struct tasklet_struct *t)
>> +static void usbnet_bh_workqueue(struct work_struct *work)
>>  {
>> -	struct usbnet *dev = from_tasklet(dev, t, bh);
>> +	struct usbnet *dev = from_work(dev, work, bh_work);
>>
>>  	usbnet_bh(&dev->delay);
>>  }
>> @@ -1742,7 +1742,7 @@ usbnet_probe (struct usb_interface *udev, const
>struct usb_device_id *prod)
>>  	skb_queue_head_init (&dev->txq);
>>  	skb_queue_head_init (&dev->done);
>>  	skb_queue_head_init(&dev->rxq_pause);
>> -	tasklet_setup(&dev->bh, usbnet_bh_tasklet);
>> +	INIT_WORK(&dev->bh_work, usbnet_bh_workqueue);
>
>workqueue is the queue, here we're talking about the work entry.
>And we use the system workqueue to schedule on (system_bh_wq) Please replace
>the workqueue with work here and in the comments

Oh, I understand what you mean. The naming is not accurate enough. 
This is not a queue but a specific execution action work.  V5 will post. 

Thanks
Jun.Miao