linux-kernel - Re: [PATCH v6 1/5] rust: debugfs: Bind DebugFS directory creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFKPJnZ2Tk3-oqBE@pollux>
Date: Wed, 18 Jun 2025 12:04:22 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Matthew Maurer <mmaurer@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Timur Tabi <ttabi@...dia.com>, Benno Lossin <lossin@...nel.org>,
	linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v6 1/5] rust: debugfs: Bind DebugFS directory creation

On Wed, Jun 18, 2025 at 02:28:13AM +0000, Matthew Maurer wrote:
> +#[cfg(CONFIG_DEBUG_FS)]
> +mod entry;
> +
> +/// Owning handle to a DebugFS directory.
> +///
> +/// This directory will be cleaned up when the handle and all child directory/file handles have
> +/// been dropped.
> +// We hold a reference to our parent if it exists to prevent the dentry we point to from being
> +// cleaned up when our parent is removed.
> +pub struct Dir(#[cfg(CONFIG_DEBUG_FS)] Option<Arc<entry::Entry>>);

NIT: Can we import Entry, such that we don't have to refer to it as entry::Entry
all the time?