linux-kernel - Re: [PATCH v11 0/6] reset: spacemit: add K1 reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250618111737-GYA157089@gentoo>
Date: Wed, 18 Jun 2025 11:17:37 +0000
From: Yixun Lan <dlan@...too.org>
To: Alex Elder <elder@...cstar.com>, Philipp Zabel <p.zabel@...gutronix.de>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	mturquette@...libre.com, sboyd@...nel.org, paul.walmsley@...ive.com,
	palmer@...belt.com, aou@...s.berkeley.edu, alex@...ti.fr,
	heylenay@....org, inochiama@...look.com, guodong@...cstar.com,
	devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
	spacemit@...ts.linux.dev, linux-riscv@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 0/6] reset: spacemit: add K1 reset support

Hi ALL,
  As the reset driver going through several review cycles,
it becomes quite calm down now, I'd like to request to merge
it into v6.17, because various drivers (pwm, emac..) will depend
on it, even in the worst case if there is problem, I believe Alex
will help to address..

Hi Philipp,
  I'd like to query if you willing to take the reset driver -
patch [5/6] through the reset tree? It sounds more intuitive,
which also will avoid potential conflicts with Kconfig/Makefile..
  I've created a prerequisite immutable tag which could be
shared between clock and reset subsytem. It's tag -
spacemit-reset-deps-for-6.17 at SpacemiT's SoC tree [1], which 
effectively are patches [1-4] of this series.
But, to make your life easy, I've also applied patch [5/6] at tag
spacemit-reset-drv-for-6.17 [2] which has a small macro adjustment
requested by Alex at [3]
  Let me know what you think of this, thanks


Link: https://github.com/spacemit-com/linux/releases/tag/spacemit-reset-deps-for-6.17 [1]
Link: https://github.com/spacemit-com/linux/releases/tag/spacemit-reset-drv-for-6.17 [2]
Link: https://lore.kernel.org/all/528522d9-0467-428c-820a-9e9c8a6166e7@riscstar.com/ [3]

On 20:11 Thu 12 Jun     , Alex Elder wrote:
> This series adds reset controller support for the SpacemiT K1 SoC.
> A SpacemiT reset controller is implemented as an auxiliary device
> associated with a clock controller (CCU).  A new header file
> holds definitions used by both the clock and reset drivers.
> 
> In this version several "multi-bit" resets have been redefined as
> individual ones.  For example, RESET_AUDIO had a mask that included
> 3 bits.  Now there are 3 separate resets (one for each bit):
> RESET_AUDIO_SYS; RESET_AUDIO_MCU_CORE; and RESET_AUDIO_APMU.
> 
> The reset symbols affected (their previous names) are:
>     RESET_USB3_0 ->
>       RESET_USB30_AHB,  RESET_USB30_VCC, RESET_USB30_PHY 
>     RESET_AUDIO ->
>       RESET_AUDIO_SYS, RESET_AUDIO_MCU, RESET_AUDIO_APMU
>     RESET_PCIE0 ->
>       RESET_PCI0_DBI, RESET_PCI0_SLV, RESET_PCI0_MSTR, RESET_PCI0_GLB
>     RESET_PCIE1 ->
>       RESET_PCI1_DBI, RESET_PCI1_SLV, RESET_PCI1_MSTR, RESET_PCI1_GLB
>     RESET_PCIE2 ->
>       RESET_PCI2_DBI, RESET_PCI2_SLV, RESET_PCI2_MSTR, RESET_PCI2_GLB
> 
> No other code has changed since v10.
> 
> All of these patches are available here:
>   https://github.com/riscstar/linux/tree/outgoing/reset-v11
> 
> 					-Alex
> 
> Between version 10 and version 11:
>   - Rebased onto Linux v6.16-rc1
>   - Redefined several "multi-bit" resets as individual ones.
> 
> Here is version 10 of this series.
>   https://lore.kernel.org/lkml/20250513215345.3631593-1-elder@riscstar.com/
> 
> All other history is available via that link, so I won't reproduce
> it again here.
> 
> Alex Elder (6):
>   dt-bindings: soc: spacemit: define spacemit,k1-ccu resets
>   soc: spacemit: create a header for clock/reset registers
>   clk: spacemit: set up reset auxiliary devices
>   clk: spacemit: define three reset-only CCUs
>   reset: spacemit: add support for SpacemiT CCU resets
>   riscv: dts: spacemit: add reset support for the K1 SoC
> 
>  .../soc/spacemit/spacemit,k1-syscon.yaml      |  29 +-
>  arch/riscv/boot/dts/spacemit/k1.dtsi          |  18 ++
>  drivers/clk/spacemit/Kconfig                  |   1 +
>  drivers/clk/spacemit/ccu-k1.c                 | 239 +++++++-------
>  drivers/reset/Kconfig                         |   9 +
>  drivers/reset/Makefile                        |   1 +
>  drivers/reset/reset-spacemit.c                | 304 ++++++++++++++++++
>  .../dt-bindings/clock/spacemit,k1-syscon.h    | 141 ++++++++
>  include/soc/spacemit/k1-syscon.h              | 160 +++++++++
>  9 files changed, 775 insertions(+), 127 deletions(-)
>  create mode 100644 drivers/reset/reset-spacemit.c
>  create mode 100644 include/soc/spacemit/k1-syscon.h
> 
> 
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> -- 
> 2.45.2
> 

-- 
Yixun Lan (dlan)