linux-kernel - Re: [PATCH v2] md/raid1: Fix stack memory use after return in raid1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d6481ddf-67e3-41ed-8ecf-d11ffdc6f4aa@gmail.com>
Date: Wed, 18 Jun 2025 19:47:13 +0800
From: Wang Jinchao <wangjinchao600@...il.com>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
 Song Liu <song@...nel.org>, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH v2] md/raid1: Fix stack memory use after return in
 raid1_reshape

On 6/16/25 19:32, Yu Kuai wrote:
> Hi,
> 
> 在 2025/06/16 18:11, Wang Jinchao 写道:
>> On 6/13/25 19:53, Wang Jinchao wrote:
>>> On 2025/6/13 17:15, Yu Kuai wrote:
>>>> Hi,
>>>>
>>>> 在 2025/06/12 20:21, Wang Jinchao 写道:
>>>>> BTW, I feel raid1_reshape can be better coding with following：
>>>>
>>>> And another hint:
>>>>
>>>> The poolinfo can be removed directly, the only other place to use it
>>>> is r1buf_pool, and can covert to pass in conf or &conf->raid_disks.
>>> Thanks, I'll review these relationships carefully before refactoring.
>>>>
>>>> Thanks,
>>>> Kuai
>>>>
Hi,
I’ve changed r1bio_pool to a pointer type and sent the patch.
As for the other two optimization suggestions, I found it challenging
to implement proper error rollback after the changes.
I tried a few times but couldn't come up with code I’m happy with,
so I’ve decided to put it on hold for now.

Thanks for your guidance.
>> .
>>
>