linux-kernel - Re: [PATCH v2 0/8] Add clock support for Loongson 2K0300 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aFQN2TSjT1IOvOt3@pie.lan>
Date: Thu, 19 Jun 2025 13:17:13 +0000
From: Yao Zi <ziyao@...root.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: Yinbo Zhu <zhuyinbo@...ngson.cn>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, WANG Xuerui <kernel@...0n.name>,
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev,
	Mingcong Bai <jeffbai@...c.io>, Kexy Biscuit <kexybiscuit@...c.io>
Subject: Re: [PATCH v2 0/8] Add clock support for Loongson 2K0300 SoC

On Thu, Jun 19, 2025 at 05:02:48PM +0800, Huacai Chen wrote:
> Hi, Yao,
> 
> I suggest dropping the last two patches temporarily, because:
> 1, the last two should be merged via another tree.
> 2, the last two depend on another series which hasn't been merged now,
> and can be squashed to that series.

These are fair points, but I think including corresponding devicetree
changes along with the binding patch helps review and proves the binding
makes sense. it should be okay to merge only parts of a series, so I
guess keeping the patches doesn't hurt, does it?

By the way, do you prefer to wait until all fundamental drivers (clock,
pinctrl, and reset) ready and merged, then merge the devicetree with all
the three devices added? Or is it just fine to go part by part, with
incremental changes to the devicetree?

Best regards,
Yao Zi

> Huacai
> 
> On Wed, Jun 18, 2025 at 12:25 AM Yao Zi <ziyao@...root.org> wrote:
> >
> > This series adds support for Loongson 2K0300's clock controller.
> > Loongson 2 clock driver is prepared to support more clock variants and
> > its flexibility is improved. All clock hardwares except the output one
> > for GMAC module are then defined.
> >
> > A clock tree dump could be obtained here[1]. This series depends on v3
> > of series "Initial support for CTCISZ Forever Pi"[2] to apply.
> >
> > [1]: https://gist.github.com/ziyao233/160bb4693e7758b2a2a996d4510b7247
> > [2]: https://lore.kernel.org/all/20250523095408.25919-1-ziyao@disroot.org/
> >
> > Changed from v1:
> > - Fold loongson,ls2k0300-clk.yaml into loongson,ls2k-clk.yaml
> > - Include the new binding header in MAINTAINERS
> > - Link to v1: https://lore.kernel.org/all/20250523104552.32742-1-ziyao@disroot.org/
> >
> > Yao Zi (8):
> >   dt-bindings: clock: loongson2: Add Loongson 2K0300 compatible
> >   clk: loongson2: Allow specifying clock flags for gate clock
> >   clk: loongson2: Support scale clocks with an alternative mode
> >   clk: loongson2: Allow zero divisors for dividers
> >   clk: loongson2: Avoid hardcoding firmware name of the reference clock
> >   clk: loongson2: Add clock definitions for Loongson 2K0300 SoC
> >   LoongArch: dts: Add clock tree for Loongson 2K0300
> >   LoongArch: dts: Remove clock-frquency from UART0 of CTCISZ Forever Pi
> >
> >  .../bindings/clock/loongson,ls2k-clk.yaml     |  26 +++-
> >  MAINTAINERS                                   |   1 +
> >  .../dts/loongson-2k0300-ctcisz-forever-pi.dts |   1 -
> >  arch/loongarch/boot/dts/loongson-2k0300.dtsi  |  17 ++-
> >  drivers/clk/clk-loongson2.c                   | 124 +++++++++++++++---
> >  .../dt-bindings/clock/loongson,ls2k0300-clk.h |  54 ++++++++
> >  6 files changed, 193 insertions(+), 30 deletions(-)
> >  create mode 100644 include/dt-bindings/clock/loongson,ls2k0300-clk.h
> >
> > --
> > 2.49.0
> >
> >