linux-kernel - Re: [Patch net-next v3] net: mana: Record doorbell physical address in PF mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250619133638.GR1699@horms.kernel.org>
Date: Thu, 19 Jun 2025 14:36:38 +0100
From: Simon Horman <horms@...nel.org>
To: longli@...rosoft.com
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shradha Gupta <shradhagupta@...ux.microsoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>,
	Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
	Erick Archer <erick.archer@...look.com>,
	linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [Patch net-next v3] net: mana: Record doorbell physical address
 in PF mode

On Tue, Jun 17, 2025 at 06:36:46PM -0700, longli@...uxonhyperv.com wrote:
> From: Long Li <longli@...rosoft.com>
> 
> MANA supports RDMA in PF mode. The driver should record the doorbell
> physical address when in PF mode.
> 
> The doorbell physical address is used by the RDMA driver to map
> doorbell pages of the device to user-mode applications through RDMA
> verbs interface. In the past, they have been mapped to user-mode while
> the device is in VF mode. With the support for PF mode implemented,
> also expose those pages in PF mode.
> 
> Support for PF mode is implemented in
> 290e5d3c49f6 ("net: mana: Add support for Multi Vports on Bare metal")
> 
> Signed-off-by: Long Li <longli@...rosoft.com>
> ---
> Changes
> v2: add more details in commit message on how the doorbell physical address is used
> v3: add the early commit detail where the support for PF mode is implemented

Thanks for the updates.

I agree that this revision address Jakub's feedback on v2.
Which in turn addressed his feedback on v1.

Reviewed-by: Simon Horman <horms@...nel.org>