linux-kernel - Re: [PATCH 3/6] regulator: spacemit: support SpacemiT P1 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b73c0d8e-9869-469e-a46a-ddec9328885e@iscas.ac.cn>
Date: Thu, 19 Jun 2025 22:13:05 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: Alex Elder <elder@...cstar.com>, lee@...nel.org, lgirdwood@...il.com,
 broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, dlan@...too.org
Cc: paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
 alex@...ti.fr, troymitchell988@...il.com, guodong@...cstar.com,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] regulator: spacemit: support SpacemiT P1 regulators

On 6/19/25 21:23, Alex Elder wrote:
> On 6/19/25 1:15 AM, Vivian Wang wrote:
>> Also, consider naming this consistently: "spacemit-p1", or
>> "spacemit-p1-regulator"?
>
> Let me see if I understand your comment, by explaining the
> naming I used.
>
> The PMIC driver could support a different PMIC.  Its OF
> match table specifies a compatible string with matching
> data, and the data describes attributes of the P1 PMIC.
> So that driver uses MOD_NAME "spacemit-pmic".
>
> This driver describes specifically the regulators found
> in the P1 PMIC, so it uses "spacemit-p1-regulator" as
> its MOD_NAME.
>
> You might still be right; but does this change what you
> are suggesting?

Oh sorry it was simpler than that. It's just I've noted that this 
regulator module file is called "spacemit-p1":

> +obj-$(CONFIG_REGULATOR_SPACEMIT_P1) += spacemit-p1.o

... but the MOD_NAME is "spacemit-p1-regulator", and I was wondering if 
it made sense to rename the module to also "spacemit-p1-regulator". In 
addition to consistency, modules are free to have all sorts of names in 
Linux, but the names have to be unique, so if this is only the regulator 
driver part, the name should reflect that.

Vivian "dramforever" Wang