linux-kernel - Re: [PATCH] mm/vma: use vmg->target to specify target VMA for new VMA merge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c54f45e3-a6ac-4749-93c0-cc9e3080ee37@lucifer.local>
Date: Thu, 19 Jun 2025 15:36:03 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Jann Horn <jannh@...gle.com>,
        Pedro Falcato <pfalcato@...e.de>, Kees Cook <kees@...nel.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/vma: use vmg->target to specify target VMA for new
 VMA merge

Hi Andrew,

Small fix-patch to correct a comment here as per Vlastimil's feedback.

Thanks, Lorenzo

----8<----
>From 0a84d237b05e6cf801933267488c8353ced7913b Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Date: Thu, 19 Jun 2025 15:32:57 +0100
Subject: [PATCH] mm: make comment consistent in vma_expand()

The VMA merge structure contains a pointer to mm_struct so we don't need to
determine it from an input VMA's vm_mm field. Update the comment to reflect
this and make it consistent with vma_merge_new_range() and
vma_merge_existing_range().

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
---
 mm/vma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vma.c b/mm/vma.c
index 13794a0ac5fe..4abed296d882 100644
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -1094,7 +1094,7 @@ struct vm_area_struct *vma_merge_new_range(struct vma_merge_struct *vmg)
  * Returns: 0 on success.
  *
  * ASSUMPTIONS:
- * - The caller must hold a WRITE lock on vmg->target->mm->mmap_lock.
+ * - The caller must hold a WRITE lock on the mm_struct->mmap_lock.
  * - The caller must have set @vmg->target and @vmg->next.
  */
 int vma_expand(struct vma_merge_struct *vmg)
--
2.49.0