linux-kernel - Re: [PATCH 0/2] ACPI: Improve SPCR handling and messaging on SPCR-less systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af292806-633e-287a-2c05-777ac7bab22b@huawei.com>
Date: Thu, 19 Jun 2025 22:42:29 +0800
From: Hanjun Guo <guohanjun@...wei.com>
To: Li Chen <me@...ux.beauty>, Catalin Marinas <catalin.marinas@....com>, Will
 Deacon <will@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown
	<lenb@...nel.org>, Liu Wei <liuwei09@...tc.cn>, Ryan Roberts
	<ryan.roberts@....com>, Andrew Morton <akpm@...ux-foundation.org>, Jonathan
 Cameron <Jonathan.Cameron@...wei.com>, Li Chen <chenl311@...natelecom.cn>,
	Sudeep Holla <sudeep.holla@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH 0/2] ACPI: Improve SPCR handling and messaging on
 SPCR-less systems

Hi Li Chen,

On 2025/6/6 15:27, Li Chen wrote:
> From: Li Chen <chenl311@...natelecom.cn>
> 
> This small series improves the kernel behavior and output when the ACPI SPCR
> table is not present or not supported.
> 
> Currently, even on systems that completely lack an SPCR table, the kernel prints:
> "Use ACPI SPCR as default console: Yes"

Agreed, this is wrong, we need to fix it.

> 
> Or if with acpi=nospcr:
> "Use ACPI SPCR as default console: No"

I think this is OK, it's just to let you know we are not
using ACPI SPCR console when ACPI is enabled, including
cases with no SPCR table.

> 
> This may mislead users into thinking an SPCR table exists
> when in fact there is no such table at all. This series addresses this in two steps:
> 
> Patch 1 ensures that acpi_parse_spcr() returns -ENODEV if CONFIG_ACPI_SPCR_TABLE is disabled.
> 
> Patch 2 updates arm64 acpi_boot_table_init() to only print the SPCR console message
> if acpi_parse_spcr() succeeds.

I have some detail comments for patch 2.

Thanks
Hanjun