linux-kernel - Re: [PATCH v2 2/6] mfd: spacemit: add support for SpacemiT PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250619144442.GI795775@google.com>
Date: Thu, 19 Jun 2025 15:44:42 +0100
From: Lee Jones <lee@...nel.org>
To: Alex Elder <elder@...cstar.com>
Cc: robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	broonie@...nel.org, lgirdwood@...il.com, wangruikang@...as.ac.cn,
	dlan@...too.org, troymitchell988@...il.com,
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu,
	alex@...ti.fr, devicetree@...r.kernel.org, spacemit@...ts.linux.dev,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: spacemit: add support for SpacemiT PMICs

On Thu, 19 Jun 2025, Alex Elder wrote:

> Add support for SpacemiT PMICs. Initially only the P1 PMIC is supported
> but the driver is structured to allow support for others to be added.
> 
> The P1 PMIC is controlled by I2C, and is normally implemented with the
> SpacemiT K1 SoC.  This PMIC provides six buck converters and 12 LDO
> regulators.  It also implements a switch, watchdog timer, real-time clock,
> and more, but initially we will only support its regulators.
> 
> Signed-off-by: Alex Elder <elder@...cstar.com>
> ---
> v2: - Use module_i2c_driver()
>     - Expanded Kconfig module help text
>     - Add MODULE_ALIAS(), and define and use DRV_NAME
> 
>  drivers/mfd/Kconfig         | 13 ++++++
>  drivers/mfd/Makefile        |  1 +
>  drivers/mfd/spacemit-pmic.c | 83 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 97 insertions(+)
>  create mode 100644 drivers/mfd/spacemit-pmic.c

All comments fro v1 are still relevant.

-- 
Lee Jones [李琼斯]