linux-kernel - Re: [PATCH net-next v4] page_pool: import Jesper's page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izOeQ7RPHABQCLP8XWfH=V+hDwBg4HTyzWhS=7CS1ZzFww@mail.gmail.com>
Date: Thu, 19 Jun 2025 10:05:37 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jesper Dangaard Brouer <hawk@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Shuah Khan <shuah@...nel.org>, Ilias Apalodimas <ilias.apalodimas@...aro.org>, 
	Toke Høiland-Jørgensen <toke@...e.dk>, 
	Ignat Korchagin <ignat@...udflare.com>
Subject: Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

On Thu, Jun 19, 2025 at 9:58 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 19 Jun 2025 08:37:05 -0700 Mina Almasry wrote:
> > Jakub, this patch was marked 'changes requested' for good reason, but
> > after investigation we found the patch itself is good and the issues
> > were elsewhere. What do I do here? A resend of v4? Or does this un
> > 'changes requested' as-is?
>
> Do you want to update the numbers in the commit msg?

Oh, I thought it's fine as-is. I can update them if need be, no need
to trouble yourself. I'll upload v5 with updated benchmark results +
make a note on how to cross build it (specify the KDIR= arg).

-- 
Thanks,
Mina