linux-kernel - Re: [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c82bf3c6-ff40-4167-a78a-4ea21e41e8e9@kernel.org>
Date: Thu, 19 Jun 2025 19:40:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: dongxuyang@...incomputing.com, p.zabel@...gutronix.de, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: ningyu@...incomputing.com, linmin@...incomputing.com,
 huangyifeng@...incomputing.com
Subject: Re: [PATCH v3 0/2] Add driver support for ESWIN eic7700 SoC reset
 controller

On 19/06/2025 09:58, dongxuyang@...incomputing.com wrote:
> From: Xuyang Dong <dongxuyang@...incomputing.com>
> 
> There are some register offsets in reset dt-bindings. It could be used.
> Therefore, we want to keep these bindings. I don't known if it meets
> the requirements.
> 
> PIPE_RST_CTRL, TBU_RST_CTRL and TEST_RST_CTRL are not used in this
> driver. Therefore, these are left out.
> 
> Updates:
> 
>   dt-bindings: reset: eswin: Documentation for eic7700 SoC
>   v2 -> v3:
>     1. Drop syscon and simple-mfd from yaml and code, because these are
>        not necessary.
>     2. Update description to introduce reset controller.
>     3. Add reset control indices for dt-bindings.
>     4. Keep the register offsets in dt-bindings.

No, drop. Register offsets are not bindings. That was last comment, so
don't keep them. Remove them.


Best regards,
Krzysztof