linux-kernel - [PATCH v1 10/55] media: i2c: hi846: Use the v4l2 helper for obtaining the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f7cfbdd2cd16ebbd43a92b0b5c12871492313c8.1750352394.git.mehdi.djait@linux.intel.com>
Date: Thu, 19 Jun 2025 19:59:03 +0200
From: Mehdi Djait <mehdi.djait@...ux.intel.com>
To: laurent.pinchart@...asonboard.com,
	sakari.ailus@...ux.intel.com
Cc: akinobu.mita@...il.com,
	stanislaw.gruszka@...ux.intel.com,
	hdegoede@...hat.com,
	arnd@...db.de,
	alain.volmat@...s.st.com,
	andrzej.hajda@...el.com,
	benjamin.mugnier@...s.st.com,
	dave.stevenson@...pberrypi.com,
	hansg@...nel.org,
	hverkuil@...all.nl,
	jacopo.mondi@...asonboard.com,
	jonas@...boo.se,
	kieran.bingham@...asonboard.com,
	khalasa@...p.pl,
	prabhakar.csengg@...il.com,
	mani@...nel.org,
	m.felsch@...gutronix.de,
	martink@...teo.de,
	mattwmajewski@...il.com,
	matthias.fend@...end.at,
	mchehab@...nel.org,
	mehdi.djait@...ux.intel.com,
	michael.riesch@...labora.com,
	naush@...pberrypi.com,
	nicholas@...hemail.net,
	nicolas.dufresne@...labora.com,
	paul.elder@...asonboard.com,
	dan.scally@...asonboard.com,
	pavel@...nel.org,
	petrcvekcz@...il.com,
	rashanmu@...il.com,
	ribalda@...omium.org,
	rmfrfs@...il.com,
	zhengsq@...k-chips.com,
	slongerbeam@...il.com,
	sylvain.petinot@...s.st.com,
	s.nawrocki@...sung.com,
	tomi.valkeinen@...asonboard.com,
	umang.jain@...asonboard.com,
	zhi.mao@...iatek.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: [PATCH v1 10/55] media: i2c: hi846: Use the v4l2 helper for obtaining the clock

devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>

diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c
index 172772decd3d..1ae5006cb9be 100644
--- a/drivers/media/i2c/hi846.c
+++ b/drivers/media/i2c/hi846.c
@@ -2052,7 +2052,7 @@ static int hi846_probe(struct i2c_client *client)
 		return ret;
 	}
 
-	hi846->clock = devm_clk_get(&client->dev, NULL);
+	hi846->clock = devm_v4l2_sensor_clk_get(&client->dev, NULL);
 	if (IS_ERR(hi846->clock)) {
 		dev_err(&client->dev, "failed to get clock: %pe\n",
 			hi846->clock);