linux-kernel - [PATCH v1 55/55] media: i2c: ov2680: Use the v4l2 helper for obtaining the clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6284706df845a3c88826f1c3bd17f60d3e71ecd9.1750352394.git.mehdi.djait@linux.intel.com>
Date: Thu, 19 Jun 2025 20:11:24 +0200
From: Mehdi Djait <mehdi.djait@...ux.intel.com>
To: laurent.pinchart@...asonboard.com,
	sakari.ailus@...ux.intel.com
Cc: akinobu.mita@...il.com,
	stanislaw.gruszka@...ux.intel.com,
	hdegoede@...hat.com,
	arnd@...db.de,
	alain.volmat@...s.st.com,
	andrzej.hajda@...el.com,
	benjamin.mugnier@...s.st.com,
	dave.stevenson@...pberrypi.com,
	hansg@...nel.org,
	hverkuil@...all.nl,
	jacopo.mondi@...asonboard.com,
	jonas@...boo.se,
	kieran.bingham@...asonboard.com,
	khalasa@...p.pl,
	prabhakar.csengg@...il.com,
	mani@...nel.org,
	m.felsch@...gutronix.de,
	martink@...teo.de,
	mattwmajewski@...il.com,
	matthias.fend@...end.at,
	mchehab@...nel.org,
	mehdi.djait@...ux.intel.com,
	michael.riesch@...labora.com,
	naush@...pberrypi.com,
	nicholas@...hemail.net,
	nicolas.dufresne@...labora.com,
	paul.elder@...asonboard.com,
	dan.scally@...asonboard.com,
	pavel@...nel.org,
	petrcvekcz@...il.com,
	rashanmu@...il.com,
	ribalda@...omium.org,
	rmfrfs@...il.com,
	zhengsq@...k-chips.com,
	slongerbeam@...il.com,
	sylvain.petinot@...s.st.com,
	s.nawrocki@...sung.com,
	tomi.valkeinen@...asonboard.com,
	umang.jain@...asonboard.com,
	zhi.mao@...iatek.com,
	linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: [PATCH v1 55/55] media: i2c: ov2680: Use the v4l2 helper for obtaining the clock

Use the new v4l2 helper devm_v4l2_sensor_clk_get() that works on both
DT- and ACPI-based platforms to retrieve a reference to the clock
producer from firmware.

Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>

diff --git a/drivers/media/i2c/ov2680.c b/drivers/media/i2c/ov2680.c
index 7237fb27ecd0..c974169c92f8 100644
--- a/drivers/media/i2c/ov2680.c
+++ b/drivers/media/i2c/ov2680.c
@@ -1079,7 +1079,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
 	struct device *dev = sensor->dev;
 	struct fwnode_handle *ep_fwnode;
 	struct gpio_desc *gpio;
-	unsigned int rate = 0;
 	int i, ret;
 
 	/*
@@ -1114,13 +1113,6 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
 
 	sensor->pwdn_gpio = gpio;
 
-	sensor->xvclk = devm_clk_get_optional(dev, "xvclk");
-	if (IS_ERR(sensor->xvclk)) {
-		ret = dev_err_probe(dev, PTR_ERR(sensor->xvclk),
-				    "xvclk clock missing or invalid\n");
-		goto out_free_bus_cfg;
-	}
-
 	/*
 	 * We could have either a 24MHz or 19.2MHz clock rate from either DT or
 	 * ACPI... but we also need to support the weird IPU3 case which will
@@ -1130,22 +1122,15 @@ static int ov2680_parse_dt(struct ov2680_dev *sensor)
 	 * uses devicetree then the configured rate should already be set, so
 	 * we can just read it.
 	 */
-	ret = fwnode_property_read_u32(dev_fwnode(dev), "clock-frequency",
-				       &rate);
-	if (ret && !sensor->xvclk) {
-		dev_err_probe(dev, ret, "invalid clock config\n");
+
+	sensor->xvclk = devm_v4l2_sensor_clk_get(dev, "xvclk");
+	if (IS_ERR(sensor->xvclk)) {
+		ret = dev_err_probe(dev, PTR_ERR(sensor->xvclk),
+				    "xvclk clock missing or invalid\n");
 		goto out_free_bus_cfg;
 	}
 
-	if (!ret && sensor->xvclk) {
-		ret = clk_set_rate(sensor->xvclk, rate);
-		if (ret) {
-			dev_err_probe(dev, ret, "failed to set clock rate\n");
-			goto out_free_bus_cfg;
-		}
-	}
-
-	sensor->xvclk_freq = rate ?: clk_get_rate(sensor->xvclk);
+	sensor->xvclk_freq = clk_get_rate(sensor->xvclk);
 
 	for (i = 0; i < ARRAY_SIZE(ov2680_xvclk_freqs); i++) {
 		if (sensor->xvclk_freq == ov2680_xvclk_freqs[i])