linux-kernel - Re: [PATCH v2] mtd: nand: brcmnand: fix mtd corrected bits stat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA_RMS5a4kB0=P+XSS_-zL+KmP2YqSSQghb=c6UvvxQg16FiQw@mail.gmail.com>
Date: Thu, 19 Jun 2025 11:23:03 -0700
From: David Regan <dregan@...adcom.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: David Regan <dregan@...adcom.com>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-mtd@...ts.infradead.org, 
	bcm-kernel-feedback-list@...adcom.com, 
	William Zhang <william.zhang@...adcom.com>, Anand Gore <anand.gore@...adcom.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Kamal Dasu <kamal.dasu@...adcom.com>, 
	Dan Beygelman <dan.beygelman@...adcom.com>, Álvaro Fernández Rojas <noltari@...il.com>, 
	rafal@...ecki.pl, computersforpeace@...il.com, frieder.schrempf@...tron.de, 
	Vignesh Raghavendra <vigneshr@...com>, Richard Weinberger <richard@....at>, 
	Boris Brezillon <bbrezillon@...nel.org>, kdasu.kdev@...il.com, 
	JaimeLiao <jaimeliao.tw@...il.com>, Adam Borowski <kilobyte@...band.pl>, 
	Jonas Gorski <jonas.gorski@...il.com>, dgcbueu@...il.com, dregan@...l.com
Subject: Re: [PATCH v2] mtd: nand: brcmnand: fix mtd corrected bits stat

Hi   Miquèl,

On Wed, Jun 18, 2025 at 2:07 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
>
> Hello David

...

> So far the reporting looks good (and the nandflipbits output looks
> correct as well).
>
> > [  676.408441] mtd_nandbiterrs: Inserted biterror @ 2/5
> > [  676.413411] mtd_nandbiterrs: rewrite page
> > [  676.418122] mtd_nandbiterrs: read_page
> > [  676.422267] mtd_nandbiterrs: verify_page
> > [  676.426194] mtd_nandbiterrs: Error: page offset 0, expected 25, got 00
> > [  676.432727] mtd_nandbiterrs: Error: page offset 1, expected a5, got 00
> > [  676.439260] mtd_nandbiterrs: Error: page offset 2, expected 65, got 05
> > [  676.445868] mtd_nandbiterrs: ECC failure, read data is incorrect
> > despite read success
>
> Here however there is something wrong. We do expect a read failure,
> instead of returning wrong data. There is still a problem, I do not know
> if this problem was there before though, but this must be fixed.
>

Thank you for highlighting this issue, I will investigate.

>
> Hello Florian, if you have time, I'd welcome you opinion on this patch :)
>
> Cheers,
> Miquèl

Thanks!

-Dave