linux-kernel - Re: [PATCH][next] clk: moxart: Make read-only array div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23f5da2f-0da1-449a-ab4e-c62fbfd74d4f@kernel.org>
Date: Thu, 19 Jun 2025 22:18:48 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Stephen Boyd <sboyd@...nel.org>, Colin Ian King <colin.i.king@...il.com>,
 Michael Turquette <mturquette@...libre.com>,
 linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] clk: moxart: Make read-only array div_idx static
 const

On 19/06/2025 21:53, Stephen Boyd wrote:
> Quoting Colin Ian King (2025-06-19 01:30:35)
>> Don't populate the read-only array div_idx on the stack at run time,
>> instead make it static const.
> 
> Why? This is in __init code so it can be thrown away if it stays on the
> stack.

Indeed previous code could be discarded, now will be in rodata, but we
save several instructions runtime on copying it. Plus the actual binary
will be slower (really less code), so also loading it will be faster.

Best regards,
Krzysztof