linux-kernel - Re: [PATCH v2] security,fs,nfs,net: update security_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhT71e7r6eS-j3o+ruciG1jyrBJ8zvrvQgaf3r+6CkgSuw@mail.gmail.com>
Date: Thu, 19 Jun 2025 17:04:06 -0400
From: Paul Moore <paul@...l-moore.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: stephen.smalley.work@...il.com, anna@...nel.org, brauner@...nel.org, 
	casey@...aufler-ca.com, davem@...emloft.net, edumazet@...gle.com, 
	horms@...nel.org, jack@...e.cz, jmorris@...ei.org, kuba@...nel.org, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-nfs@...r.kernel.org, linux-security-module@...r.kernel.org, 
	netdev@...r.kernel.org, omosnace@...hat.com, pabeni@...hat.com, 
	selinux@...r.kernel.org, serge@...lyn.com, trondmy@...nel.org, 
	viro@...iv.linux.org.uk, willemb@...gle.com
Subject: Re: [PATCH v2] security,fs,nfs,net: update security_inode_listsecurity()
 interface

On Tue, May 20, 2025 at 8:32 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
> From: Stephen Smalley <stephen.smalley.work@...il.com>
> Date: Mon, 28 Apr 2025 15:50:19 -0400
> > Update the security_inode_listsecurity() interface to allow
> > use of the xattr_list_one() helper and update the hook
> > implementations.
> >
> > Link: https://lore.kernel.org/selinux/20250424152822.2719-1-stephen.smalley.work@gmail.com/
> >
> > Signed-off-by: Stephen Smalley <stephen.smalley.work@...il.com>
> [...]
> > diff --git a/net/socket.c b/net/socket.c
> > index 9a0e720f0859..bbcaa3371fcd 100644
> > --- a/net/socket.c
> > +++ b/net/socket.c
> > @@ -560,17 +560,14 @@ static ssize_t sockfs_listxattr(struct dentry *dentry, char *buffer,
> >                               size_t size)
> >  {
> >       ssize_t len;
> > -     ssize_t used = 0;
> > +     ssize_t used, remaining;
> > +     int err;
>
> Paul: Could you sort this in the reverse xmas tree order before merging ?
> https://docs.kernel.org/process/maintainer-netdev.html#local-variable-ordering-reverse-xmas-tree-rcs

Done, thanks for reviewing the patch.

> otherwise the socket part looks good to me:
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

-- 
paul-moore.com