linux-kernel - Re: [PATCH v7 01/10] x86/fred: Provide separate IRQ vs. NMI wrappers for entry from KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1d512b0-2a98-4224-a299-5dc1a3a56f5e@intel.com>
Date: Thu, 19 Jun 2025 14:35:10 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Xin Li <xin@...or.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>
CC: "H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>, Sean Christopherson
	<seanjc@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, Zhang Rui
	<rui.zhang@...el.com>, Steven Rostedt <rostedt@...dmis.org>, Andrew Cooper
	<andrew.cooper3@...rix.com>, "Kirill A . Shutemov"
	<kirill.shutemov@...ux.intel.com>, Jacob Pan <jacob.pan@...ux.microsoft.com>,
	Andi Kleen <ak@...ux.intel.com>, Kai Huang <kai.huang@...el.com>, "Sandipan
 Das" <sandipan.das@....com>, <linux-perf-users@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 01/10] x86/fred: Provide separate IRQ vs. NMI wrappers
 for entry from KVM

On 6/18/2025 8:53 PM, Xin Li wrote:
> On 6/12/2025 2:48 PM, Sohil Mehta wrote:
>> From: Sean Christopherson <seanjc@...gle.com>
>>
>> Provide separate wrappers for forwarding IRQs vs NMIs from KVM in
>> anticipation of adding support for NMI source reporting, which will add
>> an NMI-only parameter, i.e. will further pollute the current API with a
>> param that is a hardcoded for one of the two call sites.
>>
>> Opportunistically tag the non-FRED NMI wrapper __always_inline, as the
>> compiler could theoretically generate a function call and trigger and a
>                                                                      ^
> Nit, looks to me that this is an extra "and".
> 

Ah! Will remove.

>> (completely benign) "leaving noinstr" warning.
>>
>> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
>> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> 
> Reviewed-by: Xin Li (Intel) <xin@...or.com>

Thanks