linux-kernel - Re: [PATCH v1 02/55] Documentation: media: camera-sensor: Mention v4l2_devm_sensor_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250619214705.GR22102@pendragon.ideasonboard.com>
Date: Fri, 20 Jun 2025 00:47:05 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Mehdi Djait <mehdi.djait@...ux.intel.com>
Cc: sakari.ailus@...ux.intel.com, akinobu.mita@...il.com,
	stanislaw.gruszka@...ux.intel.com, hdegoede@...hat.com,
	arnd@...db.de, alain.volmat@...s.st.com, andrzej.hajda@...el.com,
	benjamin.mugnier@...s.st.com, dave.stevenson@...pberrypi.com,
	hansg@...nel.org, hverkuil@...all.nl, jacopo.mondi@...asonboard.com,
	jonas@...boo.se, kieran.bingham@...asonboard.com, khalasa@...p.pl,
	prabhakar.csengg@...il.com, mani@...nel.org,
	m.felsch@...gutronix.de, martink@...teo.de, mattwmajewski@...il.com,
	matthias.fend@...end.at, mchehab@...nel.org,
	michael.riesch@...labora.com, naush@...pberrypi.com,
	nicholas@...hemail.net, nicolas.dufresne@...labora.com,
	paul.elder@...asonboard.com, dan.scally@...asonboard.com,
	pavel@...nel.org, petrcvekcz@...il.com, rashanmu@...il.com,
	ribalda@...omium.org, rmfrfs@...il.com, zhengsq@...k-chips.com,
	slongerbeam@...il.com, sylvain.petinot@...s.st.com,
	s.nawrocki@...sung.com, tomi.valkeinen@...asonboard.com,
	umang.jain@...asonboard.com, zhi.mao@...iatek.com,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH v1 02/55] Documentation: media: camera-sensor: Mention
 v4l2_devm_sensor_clk_get() for obtaining the clock

Hi Mehdi,

Thank you for the patch.

On Thu, Jun 19, 2025 at 07:58:55PM +0200, Mehdi Djait wrote:
> Add the new v4l2 helper devm_v4l2_sensor_clk_get() to Documentation. the
> helper works on both DT- and ACPI-based platforms to retrieve a
> reference to the clock producer from firmware.
> 
> Signed-off-by: Mehdi Djait <mehdi.djait@...ux.intel.com>
> 
> diff --git a/Documentation/driver-api/media/camera-sensor.rst b/Documentation/driver-api/media/camera-sensor.rst
> index c290833165e6..c82c018a5f40 100644
> --- a/Documentation/driver-api/media/camera-sensor.rst
> +++ b/Documentation/driver-api/media/camera-sensor.rst
> @@ -32,7 +32,8 @@ user.
>  ACPI
>  ~~~~
>  
> -Read the ``clock-frequency`` _DSD property to denote the frequency. The driver
> +Use ``devm_v4l2_sensor_clk_get()`` to get the clock. The function will read the
> +``clock-frequency`` _DSD property to denote the frequency. The driver
>  can rely on this frequency being used.

This isn't specific to ACPI anymore. I think the documentation should be
refactored further. Here's a proposal.

Handling clocks
---------------

Camera sensors have an internal clock tree including a PLL and a number of
divisors. The clock tree is generally configured by the driver based on a few
input parameters that are specific to the hardware: the external clock frequency
and the link frequency. The two parameters generally are specified by system
firmware. **No other frequencies should be used in any circumstances.**

The reason why the clock frequencies are so important is that the system is
usually designed to use specific external clock and link frequencies to ensure
electro-magnetic compatibility. Using other frequencies may cause harmful
effects elsewhere. Therefore only the pre-determined frequencies are
configurable by the user.

The external clock frequency shall be retrieved by obtaining the external clock
using the ``devm_v4l2_sensor_clk_get()`` helper function, and then getting its
frequency with ``clk_get_rate()``. Usage of the helper function guarantees
correct behaviour regardless of whether the sensor is integrated in a DT-based
or ACPI-based system.

ACPI
~~~~

ACPI-based systems typically don't register the sensor external clock with the
kernel, but specify the external clock frequency in the ``clock-frequency``
_DSD property. The ``devm_v4l2_sensor_clk_get()`` helper creates and returns a
fixed clock set at that rate.

Devicetree
~~~~~~~~~~

Devicetree-based systems declare the sensor external clock in the device tree
and reference it from the sensor node. The preferred way to select the external
clock frequency is to use the ``assigned-clocks``, ``assigned-clock-parents``
and ``assigned-clock-rates`` properties in the sensor node to set the clock
rate. See the `clock device tree bindings
<https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/clock/clock.yaml>`_
for more information. The ``devm_v4l2_sensor_clk_get()`` helper retrieves and
returns that clock.

This approach has the drawback that there's no guarantee that the frequency
hasn't been modified directly or indirectly by another driver, or supported by
the board's clock tree to begin with. Changes to the Common Clock Framework API
are required to ensure reliability.

>  
>  Devicetree

-- 
Regards,

Laurent Pinchart