linux-kernel - Re: [PATCH v1] scripts/gdb: fix parsing of MNT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ab95eac-47c0-437b-aa45-5b2871c31a8d@broadcom.com>
Date: Thu, 19 Jun 2025 14:51:16 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Stephen Brennan <stephen.s.brennan@...cle.com>,
 Tony Ambardar <tony.ambardar@...il.com>, linux-kernel@...r.kernel.org,
 linux-debuggers@...r.kernel.org
Cc: Jan Kiszka <jan.kiszka@...mens.com>, Kieran Bingham
 <kbingham@...nel.org>, Christian Brauner <brauner@...nel.org>
Subject: Re: [PATCH v1] scripts/gdb: fix parsing of MNT_* constants

On 6/3/25 09:17, Florian Fainelli wrote:
> On 6/2/25 21:42, Stephen Brennan wrote:
>> On 5/31/25 22:50, Tony Ambardar wrote:
>>> Recently, constants in linux/mount.h were changed from integer macros
>>> parsable by LX_VALUE() to enums which are not, thus breaking gdb python
>>> scripts:
>>>
>>>    Reading symbols from vmlinux...
>>>    Traceback (most recent call last):
>>>      File ".../linux/vmlinux-gdb.py", line 25, in <module>
>>>        import linux.constants
>>>      File ".../linux/scripts/gdb/linux/constants.py", line 19, in 
>>> <module>
>>>        LX_MNT_NOSUID = MNT_NOSUID
>>>    NameError: name 'MNT_NOSUID' is not defined
>>>
>>> Update to parse with LX_GDBPARSED(), which correctly handles enums.
>>>
>>> Fixes: 101f2bbab541 ("fs: convert mount flags to enum")
>>> Signed-off-by: Tony Ambardar <tony.ambardar@...il.com>
>>
>> Hi Tony,
>>
>> I was totally unaware that these constants were being consumed by
>> another debugger, and having fixed them for one, I broke them for 
>> another!
>>
>> Thanks for the fix. Having read through the preprocessor magic and this
>> change, they make sense to me. In the future, I'll be sure to make an
>> extra check for GDB users when updating enums.
>>
>> Reviewed-by: Stephen Brennan <stephen.s.brennan@...cle.com>
> 
> Not targeted to anyone in particular but this is a recurring problem, 
> the GDB scripts are typically not part of any CI and it is not natural 
> to grep for constant names outside of the C/Rust code where they are 
> being used...
> 
> I suppose that QEMU it should be much easier to ensure that GDB scripts 
> are being exercised than with my current set-up using OpenOCD + real 
> hardware...

And also:

Tested-by: Florian Fainelli <florian.fainelli@...adcom.com>

Jan, Kieran, can you please pick this up? Thanks!
-- 
Florian