linux-kernel - Re: [PATCH v7 07/10] x86/nmi: Prepare for the new NMI-source vector encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e112848f-eb8a-48fe-b70e-2146f24a113a@intel.com>
Date: Thu, 19 Jun 2025 15:23:39 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Chao Gao <chao.gao@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>, Xin Li <xin@...or.com>,
	"H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>, "Thomas
 Gleixner" <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "Borislav
 Petkov" <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, "Peter
 Zijlstra" <peterz@...radead.org>, Sean Christopherson <seanjc@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, Zhang Rui
	<rui.zhang@...el.com>, Steven Rostedt <rostedt@...dmis.org>, Andrew Cooper
	<andrew.cooper3@...rix.com>, "Kirill A . Shutemov"
	<kirill.shutemov@...ux.intel.com>, Jacob Pan <jacob.pan@...ux.microsoft.com>,
	Andi Kleen <ak@...ux.intel.com>, Kai Huang <kai.huang@...el.com>, "Sandipan
 Das" <sandipan.das@....com>, <linux-perf-users@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 07/10] x86/nmi: Prepare for the new NMI-source vector
 encoding

On 6/19/2025 12:43 AM, Chao Gao wrote:

>>
>> Suggested-by: Sean Christopherson <seanjc@...gle.com>
>> Co-developed-by: Xin Li (Intel) <xin@...or.com>
>> Signed-off-by: Xin Li (Intel) <xin@...or.com>
>> Signed-off-by: Sohil Mehta <sohil.mehta@...el.com>
> 
> Reviewed-by: Chao Gao <chao.gao@...el.com>
> 

Thanks!

> One nit below,
> 
>> --- a/arch/x86/kernel/apic/local.h
>> +++ b/arch/x86/kernel/apic/local.h
>> @@ -24,22 +24,24 @@ extern u32 x2apic_max_apicid;
>>
>> /* IPI */
>>
>> +u16 __prepare_ICR_DM_vector(u16 vector);
>> +
> 
> This seems unnecessary. local.h already includes asm/apic.h, where the function
> is defined.

I added this because 0day was flagging an issue with i386 allnoconfig.
But, thinking about it more, I'll instead move the definition of
__prepare_ICR_DM_vector() outside the CONFIG_X86_LOCAL_APIC section in
asm/apic.h.