linux-kernel - Re: [PATCH v7 02/10] x86/fred: Pass event data to the NMI entry point from KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39987c98-1f63-4a47-b15e-8c78f632da4e@intel.com>
Date: Thu, 19 Jun 2025 15:57:52 -0700
From: Sohil Mehta <sohil.mehta@...el.com>
To: Xin Li <xin@...or.com>, <x86@...nel.org>, <linux-kernel@...r.kernel.org>
CC: "H . Peter Anvin" <hpa@...or.com>, Andy Lutomirski <luto@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
	Peter Zijlstra <peterz@...radead.org>, Sean Christopherson
	<seanjc@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, Kan Liang
	<kan.liang@...ux.intel.com>, Tony Luck <tony.luck@...el.com>, Zhang Rui
	<rui.zhang@...el.com>, Steven Rostedt <rostedt@...dmis.org>, Andrew Cooper
	<andrew.cooper3@...rix.com>, "Kirill A . Shutemov"
	<kirill.shutemov@...ux.intel.com>, Jacob Pan <jacob.pan@...ux.microsoft.com>,
	Andi Kleen <ak@...ux.intel.com>, Kai Huang <kai.huang@...el.com>, "Sandipan
 Das" <sandipan.das@....com>, <linux-perf-users@...r.kernel.org>,
	<linux-edac@...r.kernel.org>, <kvm@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 02/10] x86/fred: Pass event data to the NMI entry point
 from KVM

On 6/19/2025 3:45 PM, Xin Li wrote:
> On 6/19/2025 3:15 PM, Sohil Mehta wrote:
>>
>> I want to say that the event data for IRQ has to be zero until the
>> architecture changes — Similar to the /* Reserved, must be 0 */ comment
>> in asm_fred_entry_from_kvm().
>>
> 
> FRED spec says:
> 
> For any other event, the event data are not currently defined and will 
> be zero until they are.
> 
> So "Event data not defined for IRQ thus 0."

I am fine with this. Not *defined* removes the ambiguity.