linux-kernel - Re: [net-next v4 1/3] net: ethernet: mtk_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9FD09C8D-A9DC-4270-AB4A-6EBE25959F12@public-files.de>
Date: Thu, 19 Jun 2025 09:44:34 +0200
From: Frank Wunderlich <frank-w@...lic-files.de>
To: Frank Wunderlich <linux@...web.de>, Felix Fietkau <nbd@....name>,
 Sean Wang <sean.wang@...iatek.com>, Lorenzo Bianconi <lorenzo@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Simon Horman <horms@...nel.org>
CC: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Daniel Golle <daniel@...rotopia.org>, arinc.unal@...nc9.com
Subject: Re: [net-next v4 1/3] net: ethernet: mtk_eth_soc: support named IRQs

Am 16. Juni 2025 10:07:34 MESZ schrieb Frank Wunderlich <linux@...web.de>:
>From: Frank Wunderlich <frank-w@...lic-files.de>
>
>Add named interrupts and keep index based fallback for exiting devicetrees.
>
>Currently only rx and tx IRQs are defined to be used with mt7988, but
>later extended with RSS/LRO support.
>
>Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
>Reviewed-by: Simon Horman <horms@...nel.org>
>---
>v2:
>- move irqs loading part into own helper function
>- reduce indentation
>- place mtk_get_irqs helper before the irq_handler (note for simon)
>---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 39 +++++++++++++++------
> 1 file changed, 28 insertions(+), 11 deletions(-)
>
>diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
>index b76d35069887..81ae8a6fe838 100644
>--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
>+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
>@@ -3337,6 +3337,30 @@ static void mtk_tx_timeout(struct net_device *dev, unsigned int txqueue)
> 	schedule_work(&eth->pending_work);
> }
> 
>+static int mtk_get_irqs(struct platform_device *pdev, struct mtk_eth *eth)
>+{
>+	int i;
>+
>+	eth->irq[1] = platform_get_irq_byname(pdev, "tx");
>+	eth->irq[2] = platform_get_irq_byname(pdev, "rx");

Hi Simon,

I got information that reserved frame-engine 
 irqs are not unusable and have no fixed
 meaning. So i would add fe0..fe3 in
 dts+binding and change these names from
tx/rx to fe1 and fe2.

Can i keep your RB here?

regards Frank