linux-kernel - Re: [PATCH 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd838615-d550-4e3a-9b4c-616a977fa410@linux.alibaba.com>
Date: Thu, 19 Jun 2025 09:07:21 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Linus Walleij <linus.walleij@...aro.org>, Andy Shevchenko <andy@...nel.org>,
 Orson Zhai <orsonzhai@...il.com>, Chunyan Zhang <zhang.lyra@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>, Heiko Stuebner <heiko@...ech.de>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 05/12] gpio: pmic-eic-sprd: drop unneeded .set() callback



On 2025/6/17 20:24, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> The lines on this chip are input-only. GPIO core can handle the missing
> .set() callback so there's no need to implement a dummy here. Drop it.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   drivers/gpio/gpio-pmic-eic-sprd.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
> index d9b228bea42eec53ba9d0d0945125f530a22946c..cb015fb5c9467484022723910354219e2c98d3c7 100644
> --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> @@ -109,12 +109,6 @@ static int sprd_pmic_eic_direction_input(struct gpio_chip *chip,
>   	return 0;
>   }
>   
> -static void sprd_pmic_eic_set(struct gpio_chip *chip, unsigned int offset,
> -			      int value)
> -{
> -	/* EICs are always input, nothing need to do here. */
> -}
> -
>   static int sprd_pmic_eic_set_debounce(struct gpio_chip *chip,
>   				      unsigned int offset,
>   				      unsigned int debounce)
> @@ -351,7 +345,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)
>   	pmic_eic->chip.request = sprd_pmic_eic_request;
>   	pmic_eic->chip.free = sprd_pmic_eic_free;
>   	pmic_eic->chip.set_config = sprd_pmic_eic_set_config;
> -	pmic_eic->chip.set = sprd_pmic_eic_set;
>   	pmic_eic->chip.get = sprd_pmic_eic_get;
>   	pmic_eic->chip.can_sleep = true;
>   
>